From: Randy Dunlap <rdunlap@xenotime.net>
To: linux-kernel@vger.kernel.org
Cc: akpm@linux-foundation.org, mm-commits@vger.kernel.org,
corentincj@iksaif.net, mjg@redhat.com, reintjes@google.com
Subject: Re: + drivers-platform-x86-samsung-laptopc-fix-build.patch added to -mm tree
Date: Fri, 16 Mar 2012 20:41:35 -0700 [thread overview]
Message-ID: <4F6407EF.5080403@xenotime.net> (raw)
In-Reply-To: <20120316233728.857605C0050@hpza9.eem.corp.google.com>
On 03/16/2012 03:53 PM, akpm@linux-foundation.org wrote:
> The patch titled
> Subject: drivers/platform/x86/samsung-laptop.c: fix build
> has been added to the -mm tree. Its filename is
> drivers-platform-x86-samsung-laptopc-fix-build.patch
>
See https://lkml.org/lkml/2012/3/14/25
and https://lkml.org/lkml/2012/3/14/27
from David Reintjes.
>
> ------------------------------------------------------
> From: Andrew Morton <akpm@linux-foundation.org>
> Subject: drivers/platform/x86/samsung-laptop.c: fix build
>
> gcc-4.4.4:
>
> drivers/platform/x86/samsung-laptop.c: In function 'sabi_set_commandb':
> drivers/platform/x86/samsung-laptop.c:433: error: unknown field 'd0' specified in initializer
> drivers/platform/x86/samsung-laptop.c:433: warning: missing braces around initializer
> drivers/platform/x86/samsung-laptop.c:433: warning: (near initialization for 'in.<anonymous>')
> drivers/platform/x86/samsung-laptop.c:433: error: unknown field 'd1' specified in initializer
> drivers/platform/x86/samsung-laptop.c:433: warning: excess elements in struct initializer
> drivers/platform/x86/samsung-laptop.c:433: warning: (near initialization for 'in')
> drivers/platform/x86/samsung-laptop.c:433: error: unknown field 'd2' specified in initializer
> drivers/platform/x86/samsung-laptop.c:433: warning: excess elements in struct initializer
> drivers/platform/x86/samsung-laptop.c:433: warning: (near initialization for 'in')
> drivers/platform/x86/samsung-laptop.c:433: error: unknown field 'd3' specified in initializer
> drivers/platform/x86/samsung-laptop.c:433: warning: excess elements in struct initializer
> drivers/platform/x86/samsung-laptop.c:433: warning: (near initialization for 'in')
> drivers/platform/x86/samsung-laptop.c: At top level:
> drivers/platform/x86/samsung-laptop.c:1108: warning: initialization from incompatible pointer type
>
> Cc: Corentin Chary <corentincj@iksaif.net>
> Cc: Matthew Garrett <mjg@redhat.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
>
> drivers/platform/x86/samsung-laptop.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff -puN drivers/platform/x86/samsung-laptop.c~drivers-platform-x86-samsung-laptopc-fix-build drivers/platform/x86/samsung-laptop.c
> --- a/drivers/platform/x86/samsung-laptop.c~drivers-platform-x86-samsung-laptopc-fix-build
> +++ a/drivers/platform/x86/samsung-laptop.c
> @@ -430,7 +430,7 @@ exit:
> static int sabi_set_commandb(struct samsung_laptop *samsung,
> u16 command, u8 data)
> {
> - struct sabi_data in = { .d0 = 0, .d1 = 0, .d2 = 0, .d3 = 0 };
> + struct sabi_data in = { { { .d0 = 0, .d1 = 0, .d2 = 0, .d3 = 0 } } };
>
> in.data[0] = data;
> return sabi_command(samsung, command, &in, NULL);
> _
> Subject: Subject: drivers/platform/x86/samsung-laptop.c: fix build
--
~Randy
next prev parent reply other threads:[~2012-03-17 3:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-16 22:53 + drivers-platform-x86-samsung-laptopc-fix-build.patch added to -mm tree akpm
2012-03-17 3:41 ` Randy Dunlap [this message]
2012-03-17 3:44 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F6407EF.5080403@xenotime.net \
--to=rdunlap@xenotime.net \
--cc=akpm@linux-foundation.org \
--cc=corentincj@iksaif.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=mm-commits@vger.kernel.org \
--cc=reintjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.