From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tilman Schmidt Date: Sat, 17 Mar 2012 10:31:55 +0000 Subject: Re: [PATCH] isdn: Return -EINTR in gigaset_start() if locking attempts fails. Message-Id: <4F64681B.8030406@imap.cc> MIME-Version: 1 Content-Type: multipart/mixed; boundary="------------enig4DE7A07E51A22DB415AFD90E" List-Id: References: <1331903413-11426-1-git-send-email-santoshprasadnayak@gmail.com> In-Reply-To: <1331903413-11426-1-git-send-email-santoshprasadnayak@gmail.com> To: santosh nayak Cc: hjlipp@web.de, isdn@linux-pingi.de, gigaset307x-common@lists.sourceforge.net, netdev@vger.kernel.org, linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig4DE7A07E51A22DB415AFD90E Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Am 16.03.2012 14:10, schrieb santosh nayak: > From: Santosh Nayak >=20 > If locking attempt was interrupted by a signal then we should > return -EINTR so that caller can take appropriate action. NACK. The return value of gigaset_start(), as documented in its header comment, is: * 1 - success, 0 - error Its callers rely on this. If you want to change it, you must also change the documentation and the callers accordingly. In its current form the patch would just break the driver. Thanks, Tilman --=20 Tilman Schmidt E-Mail: tilman@imap.cc Bonn, Germany Diese Nachricht besteht zu 100% aus wiederverwerteten Bits. Unge=F6ffnet mindestens haltbar bis: (siehe R=FCckseite) --------------enig4DE7A07E51A22DB415AFD90E Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/ iEYEARECAAYFAk9kaBwACgkQQ3+did9BuFsK7ACfbFVdNyHEQHIdPQBwdFoaOBRL zvwAn2VU1GEKbCVw67P6G5UQPKEWyXOM =c+S5 -----END PGP SIGNATURE----- --------------enig4DE7A07E51A22DB415AFD90E-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from out1-smtp.messagingengine.com ([66.111.4.25]:41391 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754307Ab2CQKb7 (ORCPT ); Sat, 17 Mar 2012 06:31:59 -0400 Received: from compute5.internal (compute5.nyi.mail.srv.osa [10.202.2.45]) by gateway1.nyi.mail.srv.osa (Postfix) with ESMTP id 3BD7921234 for ; Sat, 17 Mar 2012 06:31:59 -0400 (EDT) Message-ID: <4F64681B.8030406@imap.cc> Date: Sat, 17 Mar 2012 11:31:55 +0100 From: Tilman Schmidt MIME-Version: 1.0 To: santosh nayak CC: hjlipp@web.de, isdn@linux-pingi.de, gigaset307x-common@lists.sourceforge.net, netdev@vger.kernel.org, linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] isdn: Return -EINTR in gigaset_start() if locking attempts fails. References: <1331903413-11426-1-git-send-email-santoshprasadnayak@gmail.com> In-Reply-To: <1331903413-11426-1-git-send-email-santoshprasadnayak@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig4DE7A07E51A22DB415AFD90E" Sender: linux-media-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig4DE7A07E51A22DB415AFD90E Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Am 16.03.2012 14:10, schrieb santosh nayak: > From: Santosh Nayak >=20 > If locking attempt was interrupted by a signal then we should > return -EINTR so that caller can take appropriate action. NACK. The return value of gigaset_start(), as documented in its header comment, is: * 1 - success, 0 - error Its callers rely on this. If you want to change it, you must also change the documentation and the callers accordingly. In its current form the patch would just break the driver. Thanks, Tilman --=20 Tilman Schmidt E-Mail: tilman@imap.cc Bonn, Germany Diese Nachricht besteht zu 100% aus wiederverwerteten Bits. Unge=F6ffnet mindestens haltbar bis: (siehe R=FCckseite) --------------enig4DE7A07E51A22DB415AFD90E Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/ iEYEARECAAYFAk9kaBwACgkQQ3+did9BuFsK7ACfbFVdNyHEQHIdPQBwdFoaOBRL zvwAn2VU1GEKbCVw67P6G5UQPKEWyXOM =c+S5 -----END PGP SIGNATURE----- --------------enig4DE7A07E51A22DB415AFD90E--