From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nobuhiro Iwamatsu Date: Mon, 19 Mar 2012 00:54:12 +0000 Subject: Re: [PATCH 1/2] sh: dma: Collect up CHCR of SH7723 and SH7730 Message-Id: <4F6683B4.7090301@renesas.com> List-Id: References: <1331865086-20880-1-git-send-email-nobuhiro.iwamatsu.yj@renesas.com> In-Reply-To: <1331865086-20880-1-git-send-email-nobuhiro.iwamatsu.yj@renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: linux-sh@vger.kernel.org Hi, Simon Horman さんは書きました: > Hi Iwamatsu-san, > > On Fri, Mar 16, 2012 at 11:31:25AM +0900, Nobuhiro Iwamatsu wrote: >> CHCR of SH7723 and SH7730 is constitution same as SH7724. > > Can I confirm that it is intentional that this patch changes the > CHCR_TS_HIGH_MASK and CHCR_TS_HIGH_SHIFT values for sh7723 and > sh7730? Yes, you can check only sh7730. I think that sh7724 cannot be checked. Because the manual of sh7724 is not exhibited. I checked this change with manual of japanese and english. Best regards, Nobuhiro > >> Signed-off-by: Nobuhiro Iwamatsu >> --- >> arch/sh/include/cpu-sh4/cpu/dma-register.h | 10 +++------- >> 1 files changed, 3 insertions(+), 7 deletions(-) >> >> diff --git a/arch/sh/include/cpu-sh4/cpu/dma-register.h b/arch/sh/include/cpu-sh4/cpu/dma-register.h >> index 18fa80a..1af4a95 100644 >> --- a/arch/sh/include/cpu-sh4/cpu/dma-register.h >> +++ b/arch/sh/include/cpu-sh4/cpu/dma-register.h >> @@ -16,14 +16,15 @@ >> >> #define DMAOR_INIT DMAOR_DME >> >> -#if defined(CONFIG_CPU_SUBTYPE_SH7343) || \ >> - defined(CONFIG_CPU_SUBTYPE_SH7730) >> +#if defined(CONFIG_CPU_SUBTYPE_SH7343) >> #define CHCR_TS_LOW_MASK 0x00000018 >> #define CHCR_TS_LOW_SHIFT 3 >> #define CHCR_TS_HIGH_MASK 0 >> #define CHCR_TS_HIGH_SHIFT 0 >> #elif defined(CONFIG_CPU_SUBTYPE_SH7722) || \ >> + defined(CONFIG_CPU_SUBTYPE_SH7723) || \ >> defined(CONFIG_CPU_SUBTYPE_SH7724) || \ >> + defined(CONFIG_CPU_SUBTYPE_SH7730) || \ >> defined(CONFIG_CPU_SUBTYPE_SH7786) >> #define CHCR_TS_LOW_MASK 0x00000018 >> #define CHCR_TS_LOW_SHIFT 3 >> @@ -35,11 +36,6 @@ >> #define CHCR_TS_LOW_SHIFT 3 >> #define CHCR_TS_HIGH_MASK 0 >> #define CHCR_TS_HIGH_SHIFT 0 >> -#elif defined(CONFIG_CPU_SUBTYPE_SH7723) >> -#define CHCR_TS_LOW_MASK 0x00000018 >> -#define CHCR_TS_LOW_SHIFT 3 >> -#define CHCR_TS_HIGH_MASK 0 >> -#define CHCR_TS_HIGH_SHIFT 0 >> #elif defined(CONFIG_CPU_SUBTYPE_SH7757) >> #define CHCR_TS_LOW_MASK 0x00000018 >> #define CHCR_TS_LOW_SHIFT 3 >> -- >> 1.7.9.1 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-sh" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> >