From: Avi Kivity <avi@redhat.com>
To: TeLeMan <geleman@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 5/5] memory: get rid of cpu_register_io_memory()
Date: Mon, 19 Mar 2012 11:16:13 +0200 [thread overview]
Message-ID: <4F66F95D.4000608@redhat.com> (raw)
In-Reply-To: <CAETRQWkLdzRpmKL_dL=fg4yVfdiKEHET9kb7NHw6swyAxLaKJQ@mail.gmail.com>
On 03/19/2012 06:52 AM, TeLeMan wrote:
> > static bool memory_region_wrong_endianness(MemoryRegion *mr)
> > @@ -942,7 +940,7 @@ void memory_region_init_io(MemoryRegion *mr,
> > mr->opaque = opaque;
> > mr->terminates = true;
> > mr->destructor = memory_region_destructor_iomem;
> > - mr->ram_addr = cpu_register_io_memory(mr);
> > + mr->ram_addr = ~(ram_addr_t)0;
> Why not 0 but -1?
>
To catch bugs. In fact it triggered bugs (not the ones I wanted though).
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2012-03-19 9:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-08 17:20 [Qemu-devel] [PATCH 0/5] Remove cpu_register_io_memory Avi Kivity
2012-03-08 17:20 ` [Qemu-devel] [PATCH 1/5] memory: make phys_page_find() return an unadjusted section Avi Kivity
2012-03-08 17:20 ` [Qemu-devel] [PATCH 2/5] memory: store section indices in iotlb instead of io indices Avi Kivity
2012-03-08 17:20 ` [Qemu-devel] [PATCH 3/5] exec: fix code tlb entry misused as iotlb in get_page_addr_code() Avi Kivity
2012-03-15 19:23 ` jcmvbkbc
2012-03-18 10:26 ` Avi Kivity
2012-03-18 11:07 ` Max Filippov
2012-03-18 16:33 ` Avi Kivity
2012-03-18 16:45 ` Max Filippov
2012-03-08 17:20 ` [Qemu-devel] [PATCH 4/5] memory: dispatch directly via MemoryRegion Avi Kivity
2012-03-08 17:20 ` [Qemu-devel] [PATCH 5/5] memory: get rid of cpu_register_io_memory() Avi Kivity
2012-03-19 4:52 ` TeLeMan
2012-03-19 9:16 ` Avi Kivity [this message]
2012-03-19 10:37 ` TeLeMan
2012-03-19 10:48 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F66F95D.4000608@redhat.com \
--to=avi@redhat.com \
--cc=geleman@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.