From: Avi Kivity <avi@redhat.com>
To: Max Filippov <jcmvbkbc@gmail.com>, qemu-devel <qemu-devel@nongnu.org>
Cc: Jan Kiszka <jan.kiszka@siemens.com>
Subject: [Qemu-devel] Xtensa misuse of tb_invalidate_phys_page_range()?
Date: Mon, 19 Mar 2012 13:58:13 +0200 [thread overview]
Message-ID: <4F671F55.4050004@redhat.com> (raw)
void HELPER(wsr_ibreaka)(uint32_t i, uint32_t v)
{
if (env->sregs[IBREAKENABLE] & (1 << i) && env->sregs[IBREAKA + i]
!= v) {
tb_invalidate_phys_page_range(
env->sregs[IBREAKA + i], env->sregs[IBREAKA + i] + 1, 0);
tb_invalidate_phys_page_range(v, v + 1, 0);
}
env->sregs[IBREAKA + i] = v;
}
tb_invalidate_phys_page_range() expects a virtual address in user mode,
and a ram_addr_t in system mode. I'm guessing that v is a virtual address?
This needs to be fixed for system mode if so (and in any case - even if
it's a physical address, it needs to be translated to a ram_addr_t).
Similar issue for hw/kvmvapic.c.
--
error compiling committee.c: too many arguments to function
next reply other threads:[~2012-03-19 11:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-19 11:58 Avi Kivity [this message]
2012-03-19 13:51 ` [Qemu-devel] Xtensa misuse of tb_invalidate_phys_page_range()? Max Filippov
2012-03-19 14:08 ` Avi Kivity
2012-03-25 2:00 ` Max Filippov
2012-03-25 2:04 ` [Qemu-devel] [RFC] target-xtensa: fix tb invalidation for IBREAK and LOOP Max Filippov
2012-03-25 9:53 ` [Qemu-devel] Xtensa misuse of tb_invalidate_phys_page_range()? Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F671F55.4050004@redhat.com \
--to=avi@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=jcmvbkbc@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.