From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37979) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S9bP8-0002vp-Fh for qemu-devel@nongnu.org; Mon, 19 Mar 2012 08:09:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S9bP6-0005it-W3 for qemu-devel@nongnu.org; Mon, 19 Mar 2012 08:09:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:20525) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S9bP6-0005il-OD for qemu-devel@nongnu.org; Mon, 19 Mar 2012 08:09:36 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q2JC9Zc9008774 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 19 Mar 2012 08:09:35 -0400 Message-ID: <4F6721FC.6070603@redhat.com> Date: Mon, 19 Mar 2012 13:09:32 +0100 From: Gerd Hoffmann MIME-Version: 1.0 References: <1331750017-1191-1-git-send-email-alevy@redhat.com> In-Reply-To: <1331750017-1191-1-git-send-email-alevy@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH important] spice: fix broken initialization List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alon Levy Cc: qemu-devel@nongnu.org On 03/14/12 19:33, Alon Levy wrote: > Commit 1b71f7c14fab6f00c2680d4489fbee7baf796e4f moved MODULE_INIT_QOM to > way before MODULE_INIT_MACHINE, thereby breaking assumptions made in > spice-core.c which registered both a type initializer and a machine > intializer. > > This fix removes the type registration, and replaces it with calling > qemu_spice_init in vl.c after command line parsing (second pass) is > done, and after timers are armed, required by spice server. Patch added to spice patch queue. thanks, Gerd