From: Anthony Liguori <anthony@codemonkey.ws>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 3/3] configure: make full config dir path configurable
Date: Mon, 19 Mar 2012 10:13:59 -0500 [thread overview]
Message-ID: <4F674D37.7050809@codemonkey.ws> (raw)
In-Reply-To: <1332168446-9322-4-git-send-email-ehabkost@redhat.com>
On 03/19/2012 09:47 AM, Eduardo Habkost wrote:
> Instead of hardcoding $sysconfdir/qemu, let the user choose the full
> path.
>
> Signed-off-by: Eduardo Habkost<ehabkost@redhat.com>
> ---
> configure | 15 ++++++++++-----
> 1 files changed, 10 insertions(+), 5 deletions(-)
>
> diff --git a/configure b/configure
> index 8b4e3c1..98027c1 100755
> --- a/configure
> +++ b/configure
> @@ -162,6 +162,7 @@ libdir="\${prefix}/lib"
> includedir="\${prefix}/include"
> sysconfdir="\${prefix}/etc"
> confsuffix="/qemu"
> +fullconfdir=""
> slirp="yes"
> fmod_lib=""
> fmod_inc=""
> @@ -595,6 +596,8 @@ for opt do
> ;;
> --sysconfdir=*) sysconfdir="$optarg"
> ;;
> + --confdir=*) fullconfdir="$optarg"
> + ;;
> --sbindir=*|--libexecdir=*|--sharedstatedir=*|--localstatedir=*|\
> --oldincludedir=*|--datarootdir=*|--infodir=*|--localedir=*|\
> --htmldir=*|--dvidir=*|--pdfdir=*|--psdir=*)
> @@ -1010,7 +1013,8 @@ echo " --mandir=PATH install man pages in PATH"
> echo " --datadir=PATH install firmware in PATH"
> echo " --docdir=PATH install documentation in PATH"
> echo " --bindir=PATH install binaries in PATH"
> -echo " --sysconfdir=PATH install config in PATH/qemu"
> +echo " --sysconfdir=PATH install config in PATH$confsuffix"
> +echo " --confdir=PATH install config in PATH (overrides --sysconfdir)"
These semantics seem odd to me, is this similar to what autotools does? I think
that's what we're trying to match here.
Regards,
Anthony Liguori
next prev parent reply other threads:[~2012-03-19 15:14 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-19 14:47 [Qemu-devel] [PATCH 0/3] add --confdir option to configure Eduardo Habkost
2012-03-19 14:47 ` [Qemu-devel] [PATCH 1/3] Makefile: use $(confdir) instead of hardcoding $(sysconfdir)/qemu Eduardo Habkost
2012-03-19 14:47 ` [Qemu-devel] [PATCH 2/3] qemu-options.hx: refer to confdir instead of sysconfdir on docs Eduardo Habkost
2012-03-19 14:47 ` [Qemu-devel] [PATCH 3/3] configure: make full config dir path configurable Eduardo Habkost
2012-03-19 15:13 ` Anthony Liguori [this message]
2012-03-19 15:40 ` Paolo Bonzini
2012-03-19 15:14 ` [Qemu-devel] [PATCH 0/3] add --confdir option to configure Anthony Liguori
2012-03-19 15:31 ` Eduardo Habkost
2012-03-19 15:34 ` Anthony Liguori
2012-03-19 15:43 ` Eduardo Habkost
2012-03-19 15:59 ` Anthony Liguori
2012-03-19 16:09 ` Eduardo Habkost
2012-03-19 16:03 ` Eric Blake
2012-03-19 16:25 ` Anthony Liguori
2012-03-19 16:13 ` Paolo Bonzini
2012-03-19 16:20 ` Eduardo Habkost
2012-03-19 16:22 ` Anthony Liguori
2012-03-19 16:50 ` Eduardo Habkost
2012-03-19 16:31 ` Paolo Bonzini
2012-03-19 17:02 ` Eduardo Habkost
2012-03-19 16:32 ` Anthony Liguori
2012-03-19 16:34 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F674D37.7050809@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.