From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57472) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S9fMH-0004g8-8K for qemu-devel@nongnu.org; Mon, 19 Mar 2012 12:22:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S9fLs-0000Mc-MB for qemu-devel@nongnu.org; Mon, 19 Mar 2012 12:22:56 -0400 Received: from mail-pb0-f45.google.com ([209.85.160.45]:37497) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S9fLs-0000MO-Fp for qemu-devel@nongnu.org; Mon, 19 Mar 2012 12:22:32 -0400 Received: by pbcuo5 with SMTP id uo5so1464405pbc.4 for ; Mon, 19 Mar 2012 09:22:30 -0700 (PDT) Message-ID: <4F675D42.9050701@codemonkey.ws> Date: Mon, 19 Mar 2012 11:22:26 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1332168446-9322-1-git-send-email-ehabkost@redhat.com> <4F674D6E.10708@codemonkey.ws> <20120319153140.GD9375@otherpad.lan.raisama.net> <4F6751EE.2090001@codemonkey.ws> <20120319154319.GF9375@otherpad.lan.raisama.net> <4F675B22.5080604@redhat.com> <20120319162010.GJ9375@otherpad.lan.raisama.net> In-Reply-To: <20120319162010.GJ9375@otherpad.lan.raisama.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/3] add --confdir option to configure List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: Paolo Bonzini , qemu-devel@nongnu.org On 03/19/2012 11:20 AM, Eduardo Habkost wrote: > On Mon, Mar 19, 2012 at 05:13:22PM +0100, Paolo Bonzini wrote: >> Il 19/03/2012 16:43, Eduardo Habkost ha scritto: >>>> No, I'm not suggesting --package-name, I'm suggesting that qemu-kvm >>>> would carry a patch to configure that changed a fixed PACKAGE_NAME >>>> define. >>> >>> Are you really suggesting that forcing downstream to carry a patch is >>> better than having a configure option? >> >> Not downstream as in RHEL; downstream as in qemu-kvm which is a fork anyway. >> >>> If you suggest making it configurable using a variable on the 'make' >>> command-line it would be OK, but I kind of hoped that no modern software >>> project would ever require packagers to use configure-by-sed methods to >>> set build parameters. >> >> I think the package name is a pretty special case. Even with autotools, >> it's pretty much the only thing that requires configure-by-sed to change it. > > I still don't understand why, except that it's a limitation of the build > system implementation. If we don't have that restriction, I don't see > why this should be restricted by design. Because rebranding QEMU is not something we want to actively encourage downstreams to do. The fact that qemu-kvm does this is a historical artifact that we'll hopefully kill off in the near future. Regards, Anthony Liguori > Anyway, even if we decide that package name shouldn't be changed: why > changing mandir, docdir and datadir doesn't require changing the package > name, but changing /etc/qemu has to? >