From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH] ARM: tegra: Include assembler.h in sleep.S to fix build break
Date: Mon, 19 Mar 2012 10:56:32 -0600 [thread overview]
Message-ID: <4F676540.8060903@wwwdotorg.org> (raw)
In-Reply-To: <4F6764B6.6050109-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On 03/19/2012 10:54 AM, Rob Herring wrote:
> On 03/19/2012 11:50 AM, Stephen Warren wrote:
>> Commit 6f6f6a7 "ARM: create a common IOMEM definition" moved macro
>> IOMEM(), and requires users to include <asm/assembler.h>. Fix Tegra's
>> sleep.S to do so.
>>
>> Signed-off-by: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
>> ---
>> arch/arm/mach-tegra/sleep.S | 3 +++
>> 1 files changed, 3 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/mach-tegra/sleep.S b/arch/arm/mach-tegra/sleep.S
...
>> +#include <asm/assembler.h>
>> +
>
> Is there some reason you put this before linux/ include?
No. I just misremembered which order linux/ and asm/ should go in. Do
you want me to repost?
>> #include <linux/linkage.h>
>> +
>> #include <mach/io.h>
>> #include <mach/iomap.h>
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: tegra: Include assembler.h in sleep.S to fix build break
Date: Mon, 19 Mar 2012 10:56:32 -0600 [thread overview]
Message-ID: <4F676540.8060903@wwwdotorg.org> (raw)
In-Reply-To: <4F6764B6.6050109@gmail.com>
On 03/19/2012 10:54 AM, Rob Herring wrote:
> On 03/19/2012 11:50 AM, Stephen Warren wrote:
>> Commit 6f6f6a7 "ARM: create a common IOMEM definition" moved macro
>> IOMEM(), and requires users to include <asm/assembler.h>. Fix Tegra's
>> sleep.S to do so.
>>
>> Signed-off-by: Stephen Warren <swarren@wwwdotorg.org>
>> ---
>> arch/arm/mach-tegra/sleep.S | 3 +++
>> 1 files changed, 3 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/mach-tegra/sleep.S b/arch/arm/mach-tegra/sleep.S
...
>> +#include <asm/assembler.h>
>> +
>
> Is there some reason you put this before linux/ include?
No. I just misremembered which order linux/ and asm/ should go in. Do
you want me to repost?
>> #include <linux/linkage.h>
>> +
>> #include <mach/io.h>
>> #include <mach/iomap.h>
next prev parent reply other threads:[~2012-03-19 16:56 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-19 16:50 [PATCH] ARM: tegra: Include assembler.h in sleep.S to fix build break Stephen Warren
2012-03-19 16:50 ` Stephen Warren
[not found] ` <1332175831-5900-1-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-03-19 16:54 ` Rob Herring
2012-03-19 16:54 ` Rob Herring
[not found] ` <4F6764B6.6050109-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-03-19 16:56 ` Stephen Warren [this message]
2012-03-19 16:56 ` Stephen Warren
2012-03-19 16:59 ` Thierry Reding
2012-03-19 16:59 ` Thierry Reding
-- strict thread matches above, loose matches on Subject: below --
2012-03-19 17:07 Stephen Warren
2012-03-19 17:07 ` Stephen Warren
[not found] ` <1332176863-12537-1-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-03-19 18:10 ` Rob Herring
2012-03-19 18:10 ` Rob Herring
[not found] ` <4F677691.8020307-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-03-21 16:15 ` Stephen Warren
2012-03-21 16:15 ` Stephen Warren
[not found] ` <4F69FEB5.2020901-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-03-21 17:02 ` Rob Herring
2012-03-21 17:02 ` Rob Herring
[not found] ` <4F6A0999.9020104-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-03-21 17:05 ` Stephen Warren
2012-03-21 17:05 ` Stephen Warren
[not found] ` <4F6A0A44.3010304-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-03-21 17:19 ` Rob Herring
2012-03-21 17:19 ` Rob Herring
[not found] ` <4F6A0D99.2000309-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-03-26 1:50 ` Rob Herring
2012-03-26 1:50 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F676540.8060903@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=arnd-r2nGTMty4D4@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org \
--cc=robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.