Re: [PATCH 2/3] Hob: Fix advanced setting reparse mechanism

[Joshua Lock <josh@linux.intel.com>]

On 16/03/12 01:48, Dongxiao Xu wrote:
> When judging if reparse is needed when change values in advanced
> setting, we need also include user's own defined variable pairs.
>
> [YOCTO #2121]
>
> Signed-off-by: Dongxiao Xu<dongxiao.xu@intel.com>

Signed-off-by: Joshua Lock <josh@linux.intel.com>

> ---
>   lib/bb/ui/crumbs/hig.py |    2 ++
>   1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/lib/bb/ui/crumbs/hig.py b/lib/bb/ui/crumbs/hig.py
> index 67cc94e..8d73d5f 100644
> --- a/lib/bb/ui/crumbs/hig.py
> +++ b/lib/bb/ui/crumbs/hig.py
> @@ -453,6 +453,8 @@ class AdvancedSettingDialog (CrumbsDialog):
>           self.variables["PACKAGE_FORMAT"] = self.configuration.curr_package_format
>           self.variables["INCOMPATIBLE_LICENSE"] = self.configuration.incompat_license
>           self.variables["IMAGE_FSTYPES"] = self.configuration.image_fstypes
> +        for key in self.configuration.extra_setting.keys():
> +            self.variables[key] = self.configuration.extra_setting[key]
>           self.md5 = hashlib.md5(str(sorted(self.variables.items()))).hexdigest()
>           self.settings_changed = False
>

-- 
Joshua '贾詡' Lock
         Yocto Project "Johannes factotum"
         Intel Open Source Technology Centre