From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:35711)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1S9j6G-0003YX-Lm
	for qemu-devel@nongnu.org; Mon, 19 Mar 2012 16:22:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1S9j6E-0004cp-FT
	for qemu-devel@nongnu.org; Mon, 19 Mar 2012 16:22:40 -0400
Received: from mail-ob0-f173.google.com ([209.85.214.173]:34942)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1S9j6E-0004cU-AM
	for qemu-devel@nongnu.org; Mon, 19 Mar 2012 16:22:38 -0400
Received: by obbwd20 with SMTP id wd20so1431300obb.4
	for <qemu-devel@nongnu.org>; Mon, 19 Mar 2012 13:22:36 -0700 (PDT)
Message-ID: <4F67958A.1060805@codemonkey.ws>
Date: Mon, 19 Mar 2012 15:22:34 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <20120319172027.4b6915dd@doriath.home>
In-Reply-To: <20120319172027.4b6915dd@doriath.home>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] QOM: device_del core dumps qemu
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel <qemu-devel@nongnu.org>

On 03/19/2012 03:20 PM, Luiz Capitulino wrote:
>
> # qemu [..] -netdev type=tap,vhost=on,id=guest0,script=qemu-ifup-switch \
>              -device virtio-net-pci,netdev=guest0,id=foo
>
> The on the monitor:
>
> (qemu) device_del foo
> (qemu)

Pretty sure this is fixed by:

commit e5ab1404d014cefe22e9a10fca00d0acf4fe412b
Author: Anthony Liguori <aliguori@us.ibm.com>
Date:   Thu Mar 15 11:29:56 2012 -0500

     pci: fix double free of romfile property

Which I just pushed earlier today.

Could you confirm that?

Regards,

Anthony Liguori

>
> Bisect says it's caused by commit:
>
> commit dd0ba250ca83ed915ea192ab7539cdbb4e868c14
> Author: Paolo Bonzini<pbonzini@redhat.com>
> Date:   Thu Feb 2 13:08:48 2012 +0100
>
>      qdev: let QOM free properties
>
>      Drop the special free callback.  Instead, register a "regular"
>      release method in the non-legacy property.
>
>      Reviewed-by: Anthony Liguori<aliguori@us.ibm.com>
>      Signed-off-by: Paolo Bonzini<pbonzini@redhat.com>
>