All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mmc: omap: handle controller errors properly
Date: Mon, 19 Mar 2012 15:14:39 -0700	[thread overview]
Message-ID: <4F67AFCF.4040209@ti.com> (raw)
In-Reply-To: <1332195126-24719-1-git-send-email-notasas@gmail.com>

On 03/19/2012 03:12 PM, Grazvydas Ignotas wrote:
> According to OMAP3 TRM, when the controller reports certain errors,
> driver must perform a software reset. This is done by setting a bit
> in SYSCTL and waiting it to clear:
> - SRC on command timeout (CTO)
> - SRD on data errors (DTO, DCRC and DEB)
>
> This fixes a problem seen on OMAP3 pandora board with some cards
> that won't work with a message printed multiple times:
>    timedout waiting on cmd inhibit to clear
>
> Code loosely based on Linux omap_hsmmc driver.
>
> Signed-off-by: Grazvydas Ignotas<notasas@gmail.com>

Most excellent!  Pali, can you try this on N900 and see if that helps 
out the problem you were having as well?

Andy, I'll give this a spin through the boards I've got here but I'd 
like this to go, via your tree, into u-boot/master assuming all goes well.

-- 
Tom

  reply	other threads:[~2012-03-19 22:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-19 22:12 [U-Boot] [PATCH] mmc: omap: handle controller errors properly Grazvydas Ignotas
2012-03-19 22:14 ` Tom Rini [this message]
2012-03-21 19:11   ` Pali Rohár
2012-03-21 19:57     ` Pali Rohár
2012-03-19 23:21 ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F67AFCF.4040209@ti.com \
    --to=trini@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.