Re: [Qemu-devel] [PATCH] PNG screendump alternative

[Rafael da Veiga Cabral <verganic@gmail.com>]

On 03/19/2012 05:50 PM, Luiz Capitulino wrote:
> On Sat, 17 Mar 2012 19:45:56 -0300
> Rafael<verganic@gmail.com>  wrote:
>
>> Hi,
>>
>> I  had already started to work on supporting PNG dump output on
>> screendump when got to know there was another effort to do the same
>> (see Add PNG screendump thread from Daniel P. Berrange). Anyway, I'd
>> like to share my implementation which is a little bit different. It
>> does not use any resource/lib besides libpng and qemu itself and is
>> based on qemu-kvm 0.15.1 ppm_save code.
> There are a few problems with this patch. First, it should be against qemu.git
> and 0.15.1 is a bit of an old release (we're moving towards 1.1).

Ok, it's old but pretty stable component for my unstable project, but as 
you've mentioned would be a
good try to use 1.1 version and towards.

>
> Also, I'm not sure that we should completely rely on the file extension,
> maybe we should have an argument for it...

eg.: screendump -<png|tiff|jpeg> filename=path/file ?
and the ppm format as fallback.

>
> Anyway, I recommend you join the efforts for the new screendump command
> along with Marc-Andre and Alon.

Great, by increasing the solution where my proposal fits.

>> I'm using that for a personal project developed at Mandriva which uses
>> QMP directly to communicate with qemu VMs rather than using the
>> libvirt although its usage is considered for the future. There is
>> something more to show but it is just QMP related and soon I'll have
>> it done to share.
>>
>> Comments and suggestions are appreciated.
>>
>> Cheers
>> Rafael Cabral
>>

Comments appreciated, thanks Capitulino.
Rafael Cabral