From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49572) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S9nOA-0006ze-1U for qemu-devel@nongnu.org; Mon, 19 Mar 2012 20:57:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S9nO8-0004iB-6v for qemu-devel@nongnu.org; Mon, 19 Mar 2012 20:57:25 -0400 Received: from mail-yw0-f45.google.com ([209.85.213.45]:40203) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S9nO8-0004gz-0Q for qemu-devel@nongnu.org; Mon, 19 Mar 2012 20:57:24 -0400 Received: by yhoo21 with SMTP id o21so6977162yho.4 for ; Mon, 19 Mar 2012 17:57:21 -0700 (PDT) Message-ID: <4F67D5E6.1030603@gmail.com> Date: Mon, 19 Mar 2012 21:57:10 -0300 From: Rafael da Veiga Cabral MIME-Version: 1.0 References: <20120319175045.597dacef@doriath.home> In-Reply-To: <20120319175045.597dacef@doriath.home> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] PNG screendump alternative List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: qemu-devel@nongnu.org On 03/19/2012 05:50 PM, Luiz Capitulino wrote: > On Sat, 17 Mar 2012 19:45:56 -0300 > Rafael wrote: > >> Hi, >> >> I had already started to work on supporting PNG dump output on >> screendump when got to know there was another effort to do the same >> (see Add PNG screendump thread from Daniel P. Berrange). Anyway, I'd >> like to share my implementation which is a little bit different. It >> does not use any resource/lib besides libpng and qemu itself and is >> based on qemu-kvm 0.15.1 ppm_save code. > There are a few problems with this patch. First, it should be against qemu.git > and 0.15.1 is a bit of an old release (we're moving towards 1.1). Ok, it's old but pretty stable component for my unstable project, but as you've mentioned would be a good try to use 1.1 version and towards. > > Also, I'm not sure that we should completely rely on the file extension, > maybe we should have an argument for it... eg.: screendump - filename=path/file ? and the ppm format as fallback. > > Anyway, I recommend you join the efforts for the new screendump command > along with Marc-Andre and Alon. Great, by increasing the solution where my proposal fits. >> I'm using that for a personal project developed at Mandriva which uses >> QMP directly to communicate with qemu VMs rather than using the >> libvirt although its usage is considered for the future. There is >> something more to show but it is just QMP related and soon I'll have >> it done to share. >> >> Comments and suggestions are appreciated. >> >> Cheers >> Rafael Cabral >> Comments appreciated, thanks Capitulino. Rafael Cabral