From mboxrd@z Thu Jan  1 00:00:00 1970
From: Joonyoung Shim <jy0922.shim@samsung.com>
Subject: Re: [PATCH v2 09/14] drm/exynos: add G2D driver
Date: Tue, 20 Mar 2012 10:09:28 +0900
Message-ID: <4F67D8C8.4090101@samsung.com>
References: <1331891236-4302-1-git-send-email-inki.dae@samsung.com>
	<1331891236-4302-10-git-send-email-inki.dae@samsung.com>
	<CAPM=9txxK0Sv33nubTVSZnAmWgN-A+WRxKHqcv4pK0XsOm26mA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org>
Received: from mailout2.samsung.com (mailout2.samsung.com [203.254.224.25])
	by gabe.freedesktop.org (Postfix) with ESMTP id A12EF9ED98
	for <dri-devel@lists.freedesktop.org>;
	Mon, 19 Mar 2012 18:09:25 -0700 (PDT)
Received: from epcpsbgm1.samsung.com (mailout2.samsung.com [203.254.224.25])
	by mailout2.samsung.com
	(Oracle Communications Messaging Exchange Server 7u4-19.01 64bit (built
	Sep 7
	2010)) with ESMTP id <0M1500CKOSJJL760@mailout2.samsung.com> for
	dri-devel@lists.freedesktop.org; Tue, 20 Mar 2012 10:09:23 +0900 (KST)
Received: from [165.213.219.123] by mmp1.samsung.com
	(Oracle Communications Messaging Exchange Server 7u4-19.01 64bit (built
	Sep 7 2010)) with ESMTPA id <0M1500BRJSJNLU20@mmp1.samsung.com> for
	dri-devel@lists.freedesktop.org; Tue, 20 Mar 2012 10:09:23 +0900 (KST)
In-reply-to: <CAPM=9txxK0Sv33nubTVSZnAmWgN-A+WRxKHqcv4pK0XsOm26mA@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
To: Dave Airlie <airlied@gmail.com>
Cc: Inki Dae <inki.dae@samsung.com>, kyungmin.park@samsung.com, sw0312.kim@samsung.com, dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

On 03/19/2012 09:25 PM, Dave Airlie wrote:
> On Fri, Mar 16, 2012 at 9:47 AM, Inki Dae<inki.dae@samsung.com>  wrote:
>> From: Joonyoung Shim<jy0922.shim@samsung.com>
>>
>> The G2D is a 2D graphic accelerator that supports Bit Block Transfer.
>> This G2D driver is exynos drm specific and supports only G2D(version
>> 4.1) of later Exynos series from Exynos4X12 because supporting DMA.
> So just to make sure I understand, userspace generates two command
> streams, one containing registers that don't need base addresses
> and one containing registers that do contain it.
>
> Now tell me how this address security wise, since non-root users have
> the ability to use this interface.
>
> can userspace put registers that require a base address into the first
> command stream and specify any phy addr in the system?

Right, it's possible scenario. I will add codes to check it.

> If not, please
> explain in comments where this is blocked. Where is the list of
> registers the first command stream and second command stream can
> access specified?
>
> I'm not really happy about this appearing so late on the radar for
> 3.4, you really want new major userspace security features to turn up
> a lot earlier for review.

I post the patch to get the review like this and i think time posting
patch can be open always. If the patch has serious problem, certainly
don't apply it. I don't want it too, but i will try to solve it and
resend updated patch.

Thanks.