Re: [PATCH 3/4] pnfs-obj: autologin: Add support for protocol autologin

[Boaz Harrosh <bharrosh@panasas.com>]

On 03/19/2012 06:16 PM, Boaz Harrosh wrote:
> Subject: [PATCH] SQUASHME: pnf-obj: Fix as according to Trond's comments
> 

<snip>

> * Don't wait for ever for osd_login to finish, only wait osd_login_upcall_timeout
>     number of seconds, else fail.


OK I'm dropping this thing for now. The call to call_usermodehelper_xxx infrastructure
is not built for this.

What happens is that the (*cleanup) function passed to call_usermodehelper_fns is always
call from within the call_usermodehelper_fns(), before it's return. If it's waiting
for the execution - UMH_WAIT_EXEC - then just after execution, if UMH_WAIT_PROC then
after the program ends, if UMH_NO_WAIT it is called immediately. So there is no event
out of the kmode.c subsystem that can always notify us when the PROC ended.

For that I will need to either spun yet another thread, (The call_usermodehelper_exec
already spuns 3. Or change call_usermodehelper_exec to receive a third vector that
will be called on PROC completion. (Which will be redundant if  UMH_WAIT_PROC)

Since both options are too heavyweights for me right now, I will leave this option
to a TODO, and drop the timeout support for now.

Trond please confirm.

Thanks
Boaz