All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2] i.MX28: Drop __naked function from spl_mem_init
Date: Tue, 20 Mar 2012 10:21:35 +0100	[thread overview]
Message-ID: <4F684C1F.2070402@denx.de> (raw)
In-Reply-To: <201203201009.43717.marex@denx.de>

On 20/03/2012 10:09, Marek Vasut wrote:

>> In which way is this self-modifying code? I don't think so.
> 
> Because it rewrites piece of RAM, which is then called in the Data abort 
> context.

Exactly

>>
>> My understanding is that to avoid the warning we can either use this
>> "pre-compiled constant instruction" trick, or we would have to create
>> a new assembler source file for this single instruction function.
> 
> Or put it into start.S
> 
>>
>> When Marek and I discussed this, the constant seemed to be the
>> simplest approach (not the nicest, though).
> 
> Ack

Ok - Marek, I think we have clarified why we need it and why we need to
make dirty things..you do not need to change, I will apply the patch as
it is to u-boot-imx.

Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

  reply	other threads:[~2012-03-20  9:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <Message-Id: <1331903075-10468-1-git-send-email-marex@denx.de>
2012-03-16 21:32 ` [U-Boot] [PATCH V2] i.MX28: Drop __naked function from spl_mem_init Marek Vasut
2012-03-20  7:57   ` Stefano Babic
2012-03-20  8:21     ` Marek Vasut
2012-03-20  8:39     ` Wolfgang Denk
2012-03-20  9:09       ` Marek Vasut
2012-03-20  9:21         ` Stefano Babic [this message]
2012-03-20 17:38         ` Wolfgang Denk
2012-03-20  9:17       ` Stefano Babic
2012-03-20 10:43   ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F684C1F.2070402@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.