Re: [PATCH] [PATCH v3] Fetch the OVMF repository from specific git mirror and enable it

[Attilio Rao <attilio.rao@citrix.com>]

On 20/03/12 11:16, Roger Pau Monné wrote:
> 2012/3/1 Attilio Rao<attilio.rao@citrix.com>:
>    
>> Signed-off-by: Attilio Rao<attilio.rao@citrix.com>
>>
>> ---
>>
>> Differences with previous version:
>> - Add ovmf entries to .hgignore
>> - Add a rule in tools/firmware/Makefile for ovmf-find in order to cope with
>>   already cloned git repositories
>>
>> diff -r d7fe4cd831a0 -r 402a1e16b2d8 .hgignore
>> --- a/.hgignore Wed Feb 29 17:01:41 2012 +0000
>> +++ b/.hgignore Thu Mar 01 19:27:17 2012 +0000
>> @@ -287,6 +287,8 @@
>>   ^tools/xm-test/lib/XmTestLib/config.py$
>>   ^tools/xm-test/lib/XmTestReport/xmtest.py$
>>   ^tools/xm-test/tests/.*\.test$
>> +^tools/firmware/ovmf-remote
>> +^tools/firmware/ovmf$
>>   ^tools/qemu-xen-traditional-dir-remote
>>   ^tools/qemu-xen-traditional-dir$
>>   ^tools/qemu-xen-dir-remote
>> diff -r d7fe4cd831a0 -r 402a1e16b2d8 Config.mk
>> --- a/Config.mk Wed Feb 29 17:01:41 2012 +0000
>> +++ b/Config.mk Thu Mar 01 19:27:17 2012 +0000
>> @@ -187,12 +187,15 @@ QEMU_REMOTE=git://xenbits.xensource.com/
>>   endif
>>
>>   ifeq ($(GIT_HTTP),y)
>> +OVMF_UPSTREAM_URL ?= http://xenbits.xen.org/git-http/ovmf.git
>>   QEMU_UPSTREAM_URL ?= http://xenbits.xen.org/git-http/qemu-upstream-unstable.git
>>   SEABIOS_UPSTREAM_URL ?= http://xenbits.xen.org/git-http/seabios.git
>>   else
>> +OVMF_UPSTREAM_URL ?= git://xenbits.xen.org/ovmf.git
>>   QEMU_UPSTREAM_URL ?= git://xenbits.xen.org/qemu-upstream-unstable.git
>>   SEABIOS_UPSTREAM_URL ?= git://xenbits.xen.org/seabios.git
>>   endif
>> +OVMF_UPSTREAM_REVISION ?= b0855f925c6e2e0b21fbb03fab4b5fb5b6876871
>>   QEMU_UPSTREAM_REVISION ?= master
>>   SEABIOS_UPSTREAM_TAG ?= c69e288adfe6c273df4b1f3d9c223d8a4fb613cd
>>   # Wed Feb 8 20:23:36 2012 -0500
>> @@ -200,7 +203,7 @@ SEABIOS_UPSTREAM_TAG ?= c69e288adfe6c273
>>
>>   ETHERBOOT_NICS ?= rtl8139 8086100e
>>
>> -CONFIG_OVMF ?= n
>> +CONFIG_OVMF ?= y
>>      
> Since this is in the tools directory (and I think it's a tools only
> thing), shouldn't this option be set by the configure script instead
> of hardcoding it in Config.mk?
>
>    

I'm really just following SEABIOS here, whatever policy we do for OVMF 
should be mirrored in SeaBIOS I think.

Thanks,
Attilio

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel