From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nick Dyer Subject: Re: [PATCH 05/20] Input: atmel_mxt_ts - dump mxt_read/write_reg Date: Tue, 20 Mar 2012 07:43:14 -0700 Message-ID: <4F689782.3000902@itdev.co.uk> References: <1331640263-18935-1-git-send-email-djkurtz@chromium.org> <1331640263-18935-6-git-send-email-djkurtz@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1331640263-18935-6-git-send-email-djkurtz@chromium.org> Sender: linux-kernel-owner@vger.kernel.org To: Daniel Kurtz Cc: Dmitry Torokhov , Joonyoung Shim , Iiro Valkonen , Henrik Rydberg , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Benson Leung , Yufeng Shen List-Id: linux-input@vger.kernel.org Daniel Kurtz wrote: > For verbose on-the-wire debugging. > Prints DUMP_LEN bytes (in hex) per line. > > Signed-off-by: Daniel Kurtz I don't think this belongs in the driver. If you want low level i2c transfer dumps, it should go in i2c subsystem. Plus, there is the print_hex_dump function for hex dumps. cheers -- Nick Dyer Software Engineer, ITDev Ltd Hardware and Software Development Consultancy Website: http://www.itdev.co.uk