From: Avi Kivity <avi@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
kvm@vger.kernel.org, Alexey Kardashevskiy <aik@ozlabs.ru>,
qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org
Subject: Re: [PATCH RFC] virtio-pci: add MMIO property
Date: Tue, 20 Mar 2012 16:49:54 +0200 [thread overview]
Message-ID: <4F689912.7050605@redhat.com> (raw)
In-Reply-To: <20120319185723.GA8366@redhat.com>
On 03/19/2012 08:57 PM, Michael S. Tsirkin wrote:
> >
> > Should be done via an extra BAR (with the same layout, perhaps extended)
> > so compatibility is preserved.
>
> No, that would need guest changes to be of use. The point of this hack
> is to make things work for Linux guests where PIO does not work.
It only works if all guest's PCI layer knows to deal with the bit flip
correctly. I imagine it isn't true for at least the seabios virtio drivers.
--
error compiling committee.c: too many arguments to function
WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
kvm@vger.kernel.org, Alexey Kardashevskiy <aik@ozlabs.ru>,
rusty@rustcorp.com.au, qemu-devel@nongnu.org,
virtualization@lists.linux-foundation.org
Subject: Re: [Qemu-devel] [PATCH RFC] virtio-pci: add MMIO property
Date: Tue, 20 Mar 2012 16:49:54 +0200 [thread overview]
Message-ID: <4F689912.7050605@redhat.com> (raw)
In-Reply-To: <20120319185723.GA8366@redhat.com>
On 03/19/2012 08:57 PM, Michael S. Tsirkin wrote:
> >
> > Should be done via an extra BAR (with the same layout, perhaps extended)
> > so compatibility is preserved.
>
> No, that would need guest changes to be of use. The point of this hack
> is to make things work for Linux guests where PIO does not work.
It only works if all guest's PCI layer knows to deal with the bit flip
correctly. I imagine it isn't true for at least the seabios virtio drivers.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2012-03-20 14:49 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-19 15:56 [PATCH RFC] virtio-pci: add MMIO property Michael S. Tsirkin
2012-03-19 15:56 ` [Qemu-devel] " Michael S. Tsirkin
2012-03-19 17:58 ` Avi Kivity
2012-03-19 17:58 ` [Qemu-devel] " Avi Kivity
2012-03-19 18:57 ` Michael S. Tsirkin
2012-03-19 18:57 ` [Qemu-devel] " Michael S. Tsirkin
2012-03-20 14:49 ` Avi Kivity [this message]
2012-03-20 14:49 ` Avi Kivity
2012-03-19 19:19 ` Anthony Liguori
2012-03-19 19:19 ` Anthony Liguori
2012-03-19 20:49 ` Michael S. Tsirkin
2012-03-19 20:49 ` Michael S. Tsirkin
2012-03-19 21:07 ` Anthony Liguori
2012-03-19 21:07 ` [Qemu-devel] " Anthony Liguori
2012-03-19 21:20 ` Michael S. Tsirkin
2012-03-19 21:20 ` Michael S. Tsirkin
2012-03-19 21:29 ` Michael S. Tsirkin
2012-03-19 21:29 ` Michael S. Tsirkin
2012-03-19 22:13 ` Anthony Liguori
2012-03-19 22:13 ` Anthony Liguori
2012-03-19 23:52 ` Rusty Russell
2012-03-19 23:52 ` Rusty Russell
2012-03-19 23:52 ` [Qemu-devel] " Rusty Russell
2012-03-20 0:39 ` Anthony Liguori
2012-03-20 0:39 ` Anthony Liguori
2012-03-20 0:39 ` Anthony Liguori
2012-06-18 12:05 ` Michael S. Tsirkin
2012-03-19 21:07 ` Anthony Liguori
2012-03-19 19:19 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F689912.7050605@redhat.com \
--to=avi@redhat.com \
--cc=aik@ozlabs.ru \
--cc=aliguori@us.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.