From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nick Dyer Subject: Re: [PATCH 14/20] Input: atmel_mxt_ts - refactor reading object table Date: Tue, 20 Mar 2012 08:19:02 -0700 Message-ID: <4F689FE6.6020307@itdev.co.uk> References: <1331640263-18935-1-git-send-email-djkurtz@chromium.org> <1331640263-18935-15-git-send-email-djkurtz@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1331640263-18935-15-git-send-email-djkurtz@chromium.org> Sender: linux-kernel-owner@vger.kernel.org To: Daniel Kurtz Cc: Dmitry Torokhov , Joonyoung Shim , Iiro Valkonen , Henrik Rydberg , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Benson Leung , Yufeng Shen , "Tiwari, Atul" , "Bowens, Alan" List-Id: linux-input@vger.kernel.org Daniel Kurtz wrote: > Instead of reading each object separately, fetch the whole table in one > large i2c transaction. A 6 byte table object requires 10 bytes to read, > so doing this dramatically reduces overhead. > > Signed-off-by: Daniel Kurtz Yes, this looks very sensible. Acked-by: Nick Dyer -- Nick Dyer Software Engineer, ITDev Ltd Hardware and Software Development Consultancy Website: http://www.itdev.co.uk