From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34191) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SA2ak-0004Ke-FN for qemu-devel@nongnu.org; Tue, 20 Mar 2012 13:11:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SA2ae-0006oz-4w for qemu-devel@nongnu.org; Tue, 20 Mar 2012 13:11:26 -0400 Received: from 204.146.238.178.in-addr.arpa ([178.238.146.204]:57569 helo=mail.local) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SA2ad-0006ol-Tf for qemu-devel@nongnu.org; Tue, 20 Mar 2012 13:11:20 -0400 Message-ID: <4F68BA36.8010203@nowonline.co.uk> Date: Tue, 20 Mar 2012 17:11:18 +0000 From: Lee Essen MIME-Version: 1.0 References: <541C8B7E-1E25-479E-B69E-A4B58BFA45F3@nowonline.co.uk> <4F672756.9000605@web.de> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] fix incorrect bracket in tracetool List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com On 20/03/2012 16:59, Stefan Hajnoczi wrote: > On Mon, Mar 19, 2012 at 1:35 PM, Lee Essen = wrote: >> On 19 Mar 2012, at 12:32, Andreas F=E4rber wrote: >> >>> Am 19.03.2012 13:05, schrieb Lee Essen: >>> In my original (way-too-long) patch for Illumos I included fixes for=20 >>> both of the above, the approach I took was to map "bool" to "int"=20 >>> and "self" to "_self" in the dtrace part of tracetool. So it should=20 >>> have had no impact on any non-dtrace stuff. If that seems like a=20 >>> sensible approach I will look again, and at the linking issues.=20 > That sounds like it can work. > > Stefan There are only 5 bool's and 4 self's in the whole of the trace-events=20 file ... is it easier to "fix" in there, or do you think a change to=20 tracetool is the most appropriate way? Lee.