From: "Andreas Färber" <afaerber@suse.de>
To: Paul Brook <paul@codesourcery.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
QEMU Developers <qemu-devel@nongnu.org>,
Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [Qemu-devel] ARM QOM conversion / class hierarchy
Date: Tue, 20 Mar 2012 18:20:51 +0100 [thread overview]
Message-ID: <4F68BC73.9070408@suse.de> (raw)
In-Reply-To: <201203201714.09024.paul@codesourcery.com>
Am 20.03.2012 18:14, schrieb Paul Brook:
>> Make an ARMCPUClass that maps to the existing ARM support. Do *not* expose
>> all of the different features as properties. Make ARMCPUClass abstract.
>>
>> Subclass ARMCPUClass for specific models, set default flags to implement
>> the necessary logic. Expose tunables on a case-by-case basis (if there
>> needs to be a 'neon' flag for cortex-a9, then make one, but don't make
>> everything a flag just for the hell of it).
>
> As long as we can avoid the sort of duplication and redundant implementation
> that the initial .feature patch introduced. If only having a neon knob on
> some cores means we have to duplicate a whole bunch of boilerplate between
> those cores then we're doing it wrong.
Allowing to parse cpu,+/-feature is what ARMCPU::features is for.
object_new() creates an ARMCPU instance,
initfn copies ARMCPUClass::features into ARMCPU::features,
TBD sets/unsets feature flags.
That's orthogonal to imperative vs. declarative and/or inheritence.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2012-03-20 17:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-20 12:12 [Qemu-devel] ARM QOM conversion / class hierarchy Peter Maydell
2012-03-20 14:08 ` Paul Brook
2012-03-20 14:59 ` Peter Maydell
2012-03-20 16:06 ` Paul Brook
2012-03-20 16:20 ` Peter Maydell
2012-03-20 17:14 ` Paul Brook
2012-03-20 17:19 ` Peter Maydell
2012-03-20 16:56 ` Anthony Liguori
2012-03-20 17:14 ` Paul Brook
2012-03-20 17:20 ` Andreas Färber [this message]
2012-03-20 16:31 ` Michael Roth
2012-03-20 16:32 ` Peter Maydell
2012-03-20 19:04 ` Michael Roth
2012-03-20 17:01 ` Paul Brook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F68BC73.9070408@suse.de \
--to=afaerber@suse.de \
--cc=anthony@codemonkey.ws \
--cc=paul@codesourcery.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.