All of lore.kernel.org
 help / color / mirror / Atom feed
From: Timur Tabi <timur@freescale.com>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: Scott Wood <scottwood@freescale.com>,
	Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
	linuxppc-dev list <linuxppc-dev@ozlabs.org>
Subject: Re: [PATCH] powerpc/85xx: don't call of_platform_bus_probe() twice
Date: Tue, 20 Mar 2012 12:25:03 -0500	[thread overview]
Message-ID: <4F68BD6F.2090008@freescale.com> (raw)
In-Reply-To: <20120320170942.0C4143E2834@localhost>

Grant Likely wrote:

> Does a driver bind against "fsl,eloplus-dma"?  If so, then I would
> call of_platform_populate() from within the fsl,eloplus-dma driver's
> probe method.

Well, there are two "DMA" drivers.

The one in drivers/dma binds on fsl,eloplus-dma, and then manually scans
for children with the "fsl,eloplus-dma-channel" compatible.  This driver
works today because the fsl,eloplus-dma nodes are children of the SOC
node, which is already probed.

The other is in sound/soc/fsl and binds on "fsl,ssi-dma-channel".  These
are also children of the fsl,eloplus-dma node.  This driver does NOT work
today, because the fsl,eloplus-dma is not probed.

I do not want the two drivers to depend on each other.  They are
completely separate.  So I don't want to call of_platform_populate() from
the drivers/dma driver.  I could call it from the sound/soc/fsl driver,
however.  I will try to see if that works.

They only problem I see with this is that I am thinking about modifying
the drivers/dma driver to probe on "fsl,eloplus-dma-channel" channels
directly.  If I do that, then who should call of_platform_populate()?

-- 
Timur Tabi
Linux kernel developer at Freescale

  reply	other threads:[~2012-03-20 17:25 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-30 16:19 [PATCH] powerpc/85xx: don't call of_platform_bus_probe() twice Timur Tabi
2012-03-07 21:41 ` Timur Tabi
2012-03-16 20:46 ` Kumar Gala
2012-03-16 20:50   ` Timur Tabi
2012-03-19 16:04     ` Grant Likely
2012-03-19 18:43       ` Timur Tabi
2012-03-20 17:09         ` Grant Likely
2012-03-20 17:25           ` Timur Tabi [this message]
2012-03-21 15:15             ` Timur Tabi
2012-03-27 18:18               ` Timur Tabi
2012-03-28  5:01                 ` Grant Likely
2012-03-21 15:08       ` Kumar Gala
2012-04-19 20:15 ` Kumar Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F68BD6F.2090008@freescale.com \
    --to=timur@freescale.com \
    --cc=dbaryshkov@gmail.com \
    --cc=grant.likely@secretlab.ca \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=scottwood@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.