From: Jarkko Nikula <jarkko.nikula@bitmer.com>
To: Grazvydas Ignotas <notasas@gmail.com>
Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>,
alsa-devel@alsa-project.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH 3/3] ASoC: omap-mcbsp: Add period size protection mode
Date: Tue, 20 Mar 2012 21:20:56 +0200 [thread overview]
Message-ID: <4F68D898.5080606@bitmer.com> (raw)
In-Reply-To: <CANOLnOMqK5-yWoEA=1x2a4-OQYy8xvBUwY_RVdqHeaz4TxL3eQ@mail.gmail.com>
On 03/20/2012 06:42 PM, Grazvydas Ignotas wrote:
> This is what we have in pandora tree now:
> http://git.openpandora.org/cgi-bin/gitweb.cgi?p=pandora-kernel.git;a=commitdiff;h=d494977441ac8f99d094b5e03398cb33a14e832a
> Seems to work well for everything here.
>
To me this looks more like a correct fix. At quick test I got single
xrun when starting up but not endless loop of them. Maybe need to tune a
bit with CONFIG_SND_PCM_XRUN_DEBUG=y.
As a reference here are the test cases from you and Peter:
Nok:
aplay -D hw:0 -f s16_le -c 2 --period-size=512 --start-delay=50000
/dev/urandom
Ok:
aplay -D hw:0 -fs16_le -c2 --period-size=320 --buffer-size=972 \
--start-delay=81000 -v /dev/urandom
Nok:
aplay -D hw:0 -fs16_le -c2 --period-size=324 --buffer-size=972 \
--start-delay=81000 -v /dev/urandom
--
Jarkko
next prev parent reply other threads:[~2012-03-20 19:21 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-20 11:13 [PATCH 0/3] ASoC: omap-mcbsp: Constraint handling changes Peter Ujfalusi
2012-03-20 11:13 ` [PATCH 1/3] ASoC: omap-mcbsp: buffer size constraint only applies to playback stream Peter Ujfalusi
2012-03-20 15:26 ` Mark Brown
2012-03-20 16:34 ` Jarkko Nikula
2012-03-20 11:13 ` [PATCH 2/3] ASoC: omap-mcbsp: Restructure omap_mcbsp_dai_startup code Peter Ujfalusi
2012-03-20 15:27 ` Mark Brown
2012-03-20 11:13 ` [PATCH 3/3] ASoC: omap-mcbsp: Add period size protection mode Peter Ujfalusi
2012-03-20 16:01 ` Mark Brown
2012-03-20 16:15 ` Grazvydas Ignotas
2012-03-20 17:04 ` Mark Brown
2012-03-20 17:27 ` Grazvydas Ignotas
2012-03-20 18:07 ` Trent Piepho
2012-03-20 18:12 ` Mark Brown
2012-03-21 8:23 ` Peter Ujfalusi
2012-03-21 11:55 ` Grazvydas Ignotas
2012-03-20 16:20 ` Jarkko Nikula
2012-03-20 16:42 ` Grazvydas Ignotas
2012-03-20 19:20 ` Jarkko Nikula [this message]
2012-03-20 19:47 ` Trent Piepho
2012-03-21 7:57 ` Peter Ujfalusi
2012-03-21 8:13 ` Jarkko Nikula
2012-03-21 8:21 ` Peter Ujfalusi
2012-03-21 8:03 ` Peter Ujfalusi
2012-03-21 8:32 ` Jarkko Nikula
2012-03-21 8:40 ` Mark Brown
2012-03-21 9:16 ` Peter Ujfalusi
2012-03-21 9:34 ` Jarkko Nikula
2012-03-21 9:46 ` Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F68D898.5080606@bitmer.com \
--to=jarkko.nikula@bitmer.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lrg@ti.com \
--cc=notasas@gmail.com \
--cc=peter.ujfalusi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.