From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:36458)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1SA4oO-00073B-6P
	for qemu-devel@nongnu.org; Tue, 20 Mar 2012 15:33:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1SA4oL-0004xS-3v
	for qemu-devel@nongnu.org; Tue, 20 Mar 2012 15:33:39 -0400
Received: from mail-yx0-f173.google.com ([209.85.213.173]:62194)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1SA4oK-0004xH-WA
	for qemu-devel@nongnu.org; Tue, 20 Mar 2012 15:33:37 -0400
Received: by yenr5 with SMTP id r5so494377yen.4
	for <qemu-devel@nongnu.org>; Tue, 20 Mar 2012 12:33:35 -0700 (PDT)
Message-ID: <4F68DB8B.40106@codemonkey.ws>
Date: Tue, 20 Mar 2012 14:33:31 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1332185368-18708-1-git-send-email-pbonzini@redhat.com>
	<4F678A37.1020101@codemonkey.ws> <4F678E38.7050902@redhat.com>
	<4F678F6A.3050804@codemonkey.ws> <4F679576.60900@redhat.com>
	<4F679762.6000201@codemonkey.ws>
	<20120319174314.74720a38@doriath.home>
	<20120319222907.GA2994@illuin> <4F67B57E.5040802@codemonkey.ws>
	<20120319234559.GB2994@illuin> <4F67D42A.8080400@codemonkey.ws>
	<20120320091550.35959dc5@doriath.home>
In-Reply-To: <20120320091550.35959dc5@doriath.home>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC/RFA PATCH] qapi: detect extra members inside
 structs
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Eric Blake <eblake@redhat.com>, Michael Roth <mdroth@linux.vnet.ibm.com>, qemu-devel@nongnu.org

On 03/20/2012 07:15 AM, Luiz Capitulino wrote:
>> So let's work through a few examples.   Today, you have to maintain a list of
>> commands returned from query-commands and check for set membership:
>>
>> if 'query-netdev2' in commands:
>>      qmp.query_netdev2(foo)
>> else:
>>      qmp.query_netdev()
>>
>> Pretty simple.  If we have a schema representation, we'll need to be able to
>> check for arguments.
>
> Aren't we going to have the schema representation anyway? Or if we go for the
> way above we are not going to have it?

We have it, and we should expose it, but we should not IMHO require deep schema 
introspection in order for a client to make use of new functionality.

Regards,

Anthony Liguori