From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37599) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SA5JR-00041s-Pl for qemu-devel@nongnu.org; Tue, 20 Mar 2012 16:05:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SA5JM-0002jR-Rt for qemu-devel@nongnu.org; Tue, 20 Mar 2012 16:05:45 -0400 Received: from e39.co.us.ibm.com ([32.97.110.160]:41309) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SA5JM-0002hq-DQ for qemu-devel@nongnu.org; Tue, 20 Mar 2012 16:05:40 -0400 Received: from /spool/local by e39.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 20 Mar 2012 14:05:31 -0600 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by d03dlp01.boulder.ibm.com (Postfix) with ESMTP id 7D5681FF0048 for ; Tue, 20 Mar 2012 14:05:25 -0600 (MDT) Received: from d03av06.boulder.ibm.com (d03av06.boulder.ibm.com [9.17.195.245]) by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q2KK51S1104300 for ; Tue, 20 Mar 2012 14:05:05 -0600 Received: from d03av06.boulder.ibm.com (loopback [127.0.0.1]) by d03av06.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q2KK5LFY005151 for ; Tue, 20 Mar 2012 14:05:22 -0600 Message-ID: <4F68E2EC.9010309@us.ibm.com> Date: Tue, 20 Mar 2012 15:05:00 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1332272918-31746-1-git-send-email-vianac@linux.vnet.ibm.com> <1332272918-31746-2-git-send-email-vianac@linux.vnet.ibm.com> In-Reply-To: <1332272918-31746-2-git-send-email-vianac@linux.vnet.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 2/2] Change timedrift default value to slew List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?Q3LDrXN0aWFuIFZpYW5h?= Cc: qemu-devel@nongnu.org On 03/20/2012 02:48 PM, Crístian Viana wrote: > Windows 2008+ is very sensitive to missed ticks. The RTC is used by default as > the time source. If time drift is not enabled, Windows is prone to > blue screening. > > Signed-off-by: Crístian Viana > --- > vl.c | 13 ++++++++++++- > 1 files changed, 12 insertions(+), 1 deletions(-) > > diff --git a/vl.c b/vl.c > index 112b0e0..2c7cbf0 100644 > --- a/vl.c > +++ b/vl.c > @@ -550,11 +550,22 @@ static void configure_rtc(QemuOpts *opts) > > qdev_prop_register_global_list(slew_lost_ticks); > } else if (!strcmp(value, "none")) { > - /* discard is default */ > + /* do nothing */ > } else { > fprintf(stderr, "qemu: invalid option value '%s'\n", value); > exit(1); > } > + } else { > + static GlobalProperty slew_lost_ticks[] = { > + { > + .driver = "mc146818rtc", > + .property = "lost_tick_policy", > + .value = "slew", > + }, > + { /* end of list */ } > + }; I think we just want to change: hw/mc146818rtc.h: DEFINE_PROP_LOSTTICKPOLICY("lost_tick_policy", RTCState, lost_tick_policy, LOST_TICK_DISCARD), I think we just need to change this to LOST_TICK_SLEW. This would effectively change the default. Regards, Anthony Liguori > + qdev_prop_register_global_list(slew_lost_ticks); > } > } >