From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52012) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SA8iY-0000X5-HH for qemu-devel@nongnu.org; Tue, 20 Mar 2012 19:43:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SA8iW-0003C3-P5 for qemu-devel@nongnu.org; Tue, 20 Mar 2012 19:43:54 -0400 Received: from v220110690675601.yourvserver.net ([78.47.199.172]:60480) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SA8iW-0003Bw-IM for qemu-devel@nongnu.org; Tue, 20 Mar 2012 19:43:52 -0400 Message-ID: <4F691635.10006@weilnetz.de> Date: Wed, 21 Mar 2012 00:43:49 +0100 From: Stefan Weil MIME-Version: 1.0 References: <1332254938-31023-1-git-send-email-walimisdev@gmail.com> <1332254938-31023-2-git-send-email-walimisdev@gmail.com> In-Reply-To: <1332254938-31023-2-git-send-email-walimisdev@gmail.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/2] hw/pflash_cfi01: change print method to avoid complaint List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Liming Wang Cc: Anthony Liguori , qemu-devel@nongnu.org Am 20.03.2012 15:48, schrieb Liming Wang: > Linux guest os often writes invalid cmd data to reset into read mode, > which leads many qemu complaint. Here we place all the debug > message into macro PFLASH_DEBUG. We can turn on the all debug info by > define PFLASH_DEBUG if we want to debug pflash_cfi01. > > Signed-off-by: Liming Wang > --- > hw/pflash_cfi01.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/hw/pflash_cfi01.c b/hw/pflash_cfi01.c > index 2e6fa71..4e39ea6 100644 > --- a/hw/pflash_cfi01.c > +++ b/hw/pflash_cfi01.c > @@ -433,7 +433,7 @@ static void pflash_write(pflash_t *pfl, > target_phys_addr_t offset, > return; > > error_flash: > - printf("%s: Unimplemented flash cmd sequence " > + DPRINTF("%s: Unimplemented flash cmd sequence " > "(offset " TARGET_FMT_plx ", wcycle 0x%x cmd 0x%x value 0x%x)\n", > __func__, offset, pfl->wcycle, pfl->cmd, value); Using the trace mechanism of QEMU might be better here than DPRINTF It allows users to enable trace messages without recompilation. See docs/tracing.txt for details. I personally like this special printf statement, because it shows me since several years that there _are_ flash command sequences which should be implemented (just boot MIPS Malta with Linux). Maybe one day I'll fix them. With DPRINTF, I'll never again get a reminder. Regards, Stefan Weil