All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Weil <sw@weilnetz.de>
To: Jia Liu <proljc@gmail.com>
Cc: qemu-devel@nongnu.org, aurelien@aurel32.net
Subject: Re: [Qemu-devel] [PATCH 1/4] add MIPS DSP helpers define
Date: Wed, 21 Mar 2012 09:17:58 +0100	[thread overview]
Message-ID: <4F698EB6.2060301@weilnetz.de> (raw)
In-Reply-To: <1331541159-5218-2-git-send-email-proljc@gmail.com>

Am 12.03.2012 09:32, schrieb Jia Liu:
>
> This patch is the helper define of MIPS ASE DSP.
>
> Signed-off-by: Jia Liu <proljc@gmail.com>
> ---
> target-mips/helper.h | 152 
> ++++++++++++++++++++++++++++++++++++++++++++++++++
> 1 files changed, 152 insertions(+), 0 deletions(-)
>
> diff --git a/target-mips/helper.h b/target-mips/helper.h
> index 442f684..1abf582 100644
> --- a/target-mips/helper.h
> +++ b/target-mips/helper.h
> @@ -297,4 +297,156 @@ DEF_HELPER_0(rdhwr_ccres, tl)
> DEF_HELPER_1(pmon, void, int)
> DEF_HELPER_0(wait, void)
>
> +/* MIPS32 DSP */
> +DEF_HELPER_1(absqsph, i32, i32)
> +DEF_HELPER_1(absqsw, i32, i32)
> +DEF_HELPER_2(addqph, i32, i32, i32)
> +DEF_HELPER_2(addqsph, i32, i32, i32)
[snip]

Hi,

I know that a lot of people love such tabulated code, but I personally
would prefer to see those DEF_HELPER lines using the style which
is used in the existing code (one space after comma).

Regards,
Stefan Weil

  reply	other threads:[~2012-03-21  8:18 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-12  8:32 [Qemu-devel] [PATCH 0/4] MIPS ASE DSP Support for Qemu Jia Liu
2012-03-12  8:32 ` [Qemu-devel] [PATCH 1/4] add MIPS DSP helpers define Jia Liu
2012-03-21  8:17   ` Stefan Weil [this message]
2012-03-22 13:45     ` Jia Liu
2012-03-12  8:32 ` [Qemu-devel] [PATCH 2/4] add MIPS DSP helpers implement Jia Liu
2012-03-21  8:22   ` Stefan Weil
2012-03-12  8:32 ` [Qemu-devel] [PATCH 3/4] add MIPS DSP translation Jia Liu
2012-03-21  8:33   ` Stefan Weil
2012-03-12  8:32 ` [Qemu-devel] [PATCH 4/4] add MIPS DSP testcase Jia Liu
2012-03-21  8:38   ` Stefan Weil
2012-03-21  0:12 ` [Qemu-devel] [PATCH 0/4] MIPS ASE DSP Support for Qemu Jia Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F698EB6.2060301@weilnetz.de \
    --to=sw@weilnetz.de \
    --cc=aurelien@aurel32.net \
    --cc=proljc@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.