From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43772) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SAGog-0002jE-62 for qemu-devel@nongnu.org; Wed, 21 Mar 2012 04:22:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SAGob-0007b4-BV for qemu-devel@nongnu.org; Wed, 21 Mar 2012 04:22:45 -0400 Received: from v220110690675601.yourvserver.net ([78.47.199.172]:47867) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SAGob-0007ai-52 for qemu-devel@nongnu.org; Wed, 21 Mar 2012 04:22:41 -0400 Message-ID: <4F698FCE.2070400@weilnetz.de> Date: Wed, 21 Mar 2012 09:22:38 +0100 From: Stefan Weil MIME-Version: 1.0 References: <1331541159-5218-1-git-send-email-proljc@gmail.com> <1331541159-5218-3-git-send-email-proljc@gmail.com> In-Reply-To: <1331541159-5218-3-git-send-email-proljc@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/4] add MIPS DSP helpers implement List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jia Liu Cc: qemu-devel@nongnu.org, aurelien@aurel32.net Am 12.03.2012 09:32, schrieb Jia Liu: > This patch is the helper implementation of MIPS ASE DSP. > > Signed-off-by: Jia Liu > --- > target-mips/op_helper.c | 3936 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 3936 insertions(+), 0 deletions(-) > > diff --git a/target-mips/op_helper.c b/target-mips/op_helper.c > index 87e9799..e6ff3c9 100644 > --- a/target-mips/op_helper.c > +++ b/target-mips/op_helper.c > @@ -3409,3 +3409,3939 @@ FOP_COND_PS(le, float32_le(fst0, fst1,&env->active_fpu.fp_status), > float32_le(fsth0, fsth1,&env->active_fpu.fp_status)) > FOP_COND_PS(ngt, float32_unordered(fst1, fst0,&env->active_fpu.fp_status) || float32_le(fst0, fst1,&env->active_fpu.fp_status), > float32_unordered(fsth1, fsth0,&env->active_fpu.fp_status) || float32_le(fsth0, fsth1,&env->active_fpu.fp_status)) > + > +/* MIPS DSP functions begin */ > +static inline void set_DSPControl_overflow_flag (uint32_t flag, int position) > Please check your patches using scripts/checkpatch.pl. There should be no space between function name and argument list for new functions (some old functions still have that space, but that's accepted). > +{ > + env->active_tc.DSPControl |= (target_ulong)flag<< position; > +} > + >