From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/6] Add the systemd package
Date: Wed, 21 Mar 2012 10:33:11 +0100 [thread overview]
Message-ID: <4F69A057.9010905@free-electrons.com> (raw)
In-Reply-To: <201203201919.39532.arnout@mind.be>
Le 20/03/2012 19:19, Arnout Vandecappelle a ?crit :
> On Tuesday 20 March 2012 09:35:55 Maxime Ripard wrote:
> [snip]
>>>> diff --git a/package/systemd/getty at .service b/package/systemd/getty at .service
>>> [snip]
>>>> diff --git a/package/systemd/serial-getty at .service b/package/systemd/serial-getty at .service
>>>
>>> AFAICS the only difference between these two files and the upstream
>>> version is that it's getty instead of agetty. Wouldn't it be simpler
>>> and more future-safe to patch the upstream files?
>>
>> Probably. I'll send a patch and see how it turns out.
>> In the meantime, maybe I can just put a patch here instead of the whole
>> file.
>
> That's what I meant. I doubt that upstream would accept a patch that
> removes agetty. Maybe a patch that makes it configurable in the m4
> file, but that's a lot more work to cook.
>
> BTW, I just noticed now that the 'normal' service definition files
> are installed in /lib/systemd/system rather than /etc/systemd/system.
>
> [snip]
>>>> +define SYSTEMD_INSTALL_TTY_HOOK
>>>> + rm -f $(TARGET_DIR)/etc/systemd/system/getty.target.wants/getty at tty1.service
>>>> + [ -f $(TARGET_DIR)/etc/systemd/system/getty at .service ] || \
>>>> + $(INSTALL) -D package/systemd/getty at .service \
>>>> + $(TARGET_DIR)/etc/systemd/system/
>>>> + [ -f $(TARGET_DIR)/etc/systemd/system/serial-getty at .service ] || \
>>>> + $(INSTALL) -D package/systemd/serial-getty at .service \
>>>> + $(TARGET_DIR)/etc/systemd/system/
>>>> + ln -fs ../serial-getty at .service $(TARGET_DIR)/etc/systemd/system/getty.target.wants/serial-getty@$(BR2_TARGET_GENERIC_GETTY_PORT).service
>>>
>>> This looks strange to me. Admittedly, I've never used systemd and
>>> don't really know how it works. But to me, this looks like the
>>> getty at .service is actually not used.
>>
>> Well, actually, this symlink with weird names is used as the way to pass
>> units some arguments.
>
> That much I know :-)
>
> My point is: the getty at tty1.service file is removed. Therefore, there
> is nobody using the getty at .service generic definition. At least that's
> my understanding of how systemd works. So why install the
> getty at .service file?
Aaah. I see your point now. Sorry I went a bit off-topic :)
You're right, of course, I'll remove it.
--
Maxime Ripard, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2012-03-21 9:33 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-19 15:59 [Buildroot] [pull request] Pull request for branch for-2012.05/systemd Maxime Ripard
2012-03-19 15:59 ` [Buildroot] [PATCH 1/6] Change the /etc/mtab symlink to use an absolute path Maxime Ripard
2012-03-19 16:08 ` Peter Korsgaard
2012-03-19 15:59 ` [Buildroot] [PATCH 2/6] Add the systemd package Maxime Ripard
2012-03-19 23:32 ` Arnout Vandecappelle
2012-03-20 8:35 ` Maxime Ripard
2012-03-20 8:46 ` Peter Korsgaard
2012-03-20 18:19 ` Arnout Vandecappelle
2012-03-21 9:33 ` Maxime Ripard [this message]
2012-03-19 15:59 ` [Buildroot] [PATCH 3/6] Enable cgroups in Linux if we use systemd Maxime Ripard
2012-03-19 15:59 ` [Buildroot] [PATCH 4/6] Rework of the init system Maxime Ripard
2012-03-19 23:45 ` Arnout Vandecappelle
2012-03-20 8:53 ` Maxime Ripard
2012-03-20 9:15 ` Peter Korsgaard
2012-03-20 9:14 ` Peter Korsgaard
2012-03-19 15:59 ` [Buildroot] [PATCH 5/6] Fix installation for the lighttpd package Maxime Ripard
2012-03-19 23:51 ` Arnout Vandecappelle
2012-03-20 9:42 ` Maxime Ripard
2012-03-20 12:29 ` Arnout Vandecappelle
2012-03-19 15:59 ` [Buildroot] [PATCH 6/6] Add systemd unit for lighttpd Maxime Ripard
2012-03-19 23:55 ` Arnout Vandecappelle
2012-03-21 9:24 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F69A057.9010905@free-electrons.com \
--to=maxime.ripard@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.