Re: [PATCH 3/3] ASoC: omap-mcbsp: Add period size protection mode

[Peter Ujfalusi <peter.ujfalusi@ti.com>]

On 03/21/2012 11:34 AM, Jarkko Nikula wrote:
> On 03/21/2012 11:16 AM, Peter Ujfalusi wrote:
>> Agreed. Let's drop this patch, and try to figure out something which can
>> be used by other platforms as well.
>>
>> I would keep the first two patch in this series..
>>
> I acked already 1/3 but 2/3 needs commit log update and change below
> looks suspicious for omap1 and 2.

True, I'll update the commit log for patch 2.

> @@ -120,6 +120,9 @@ static int omap_mcbsp_dai_startup(struct
> snd_pcm_substream *substream,
>  	if (!cpu_dai->active)
>  		err = omap_mcbsp_request(mcbsp);
> 
> +	if (!mcbsp->pdata->buffer_size)
> +		return err;

We only need to set the constraints on OMAP versions which have FIFO. If
buffer_size is 0 we can just return without going forward.
It removes one level of nested code in the function.

-- 
Péter