From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Lezcano Subject: Re: [RFC][PATCH 1/7] ARM: OMAP4: cpuidle - Remove unused valid field Date: Wed, 21 Mar 2012 10:46:34 +0100 Message-ID: <4F69A37A.7020606@linaro.org> References: <1332322070-24577-1-git-send-email-daniel.lezcano@linaro.org> <1332322070-24577-2-git-send-email-daniel.lezcano@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-bk0-f46.google.com ([209.85.214.46]:50810 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753739Ab2CUJqi (ORCPT ); Wed, 21 Mar 2012 05:46:38 -0400 Received: by bkcik5 with SMTP id ik5so723963bkc.19 for ; Wed, 21 Mar 2012 02:46:37 -0700 (PDT) In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: "Shilimkar, Santosh" Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linaro-dev@lists.linaro.org On 03/21/2012 10:41 AM, Shilimkar, Santosh wrote: > On Wed, Mar 21, 2012 at 2:57 PM, Daniel Lezcano > wrote: >> The 'valid' field is never used in the code, let's remove it. >> >> Signed-off-by: Daniel Lezcano >> --- > It is used during the registration. This field has been very useful f= or > debug when need to disable a C-state etc. > So unless and until there is a strong reason, i would like to retain = it. IMO if it used for debug purpose, it should be moved to the debug code=20 and if the debug code is not upstream, then that 'valid' should not be=20 here but in the out-of-tree code. By the way, this may be a debate for nothing because a patchset is on=20 the way to disable C-states from sysfs. --=20 Linaro.org =E2=94=82 Open source software fo= r ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-omap" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: daniel.lezcano@linaro.org (Daniel Lezcano) Date: Wed, 21 Mar 2012 10:46:34 +0100 Subject: [RFC][PATCH 1/7] ARM: OMAP4: cpuidle - Remove unused valid field In-Reply-To: References: <1332322070-24577-1-git-send-email-daniel.lezcano@linaro.org> <1332322070-24577-2-git-send-email-daniel.lezcano@linaro.org> Message-ID: <4F69A37A.7020606@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 03/21/2012 10:41 AM, Shilimkar, Santosh wrote: > On Wed, Mar 21, 2012 at 2:57 PM, Daniel Lezcano > wrote: >> The 'valid' field is never used in the code, let's remove it. >> >> Signed-off-by: Daniel Lezcano >> --- > It is used during the registration. This field has been very useful for > debug when need to disable a C-state etc. > So unless and until there is a strong reason, i would like to retain it. IMO if it used for debug purpose, it should be moved to the debug code and if the debug code is not upstream, then that 'valid' should not be here but in the out-of-tree code. By the way, this may be a debate for nothing because a patchset is on the way to disable C-states from sysfs. -- Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog