All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jun'ichi Nomura" <j-nomura@ce.jp.nec.com>
To: device-mapper development <dm-devel@redhat.com>,
	Mikulas Patocka <mpatocka@redhat.com>
Cc: "Alasdair G. Kergon" <agk@redhat.com>,
	Jens Axboe <axboe@kernel.dk>,
	linux-kernel@vger.kernel.org
Subject: Re: [dm-devel] [PATCH] Fix I/O counts in vmstat
Date: Wed, 21 Mar 2012 19:04:08 +0900	[thread overview]
Message-ID: <4F69A798.4000200@ce.jp.nec.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1203202336370.15617@file.rdu.redhat.com>

Hi Mikulas,

> The decision whether bio is counted or not is made by the code that
> submits the bio. This leads to some problems:

How about convering dm targets to use generic_make_request?

Since submit_bio counts vm events, it seems natural for
caller to decide which function to use.
Device driver does not know whether the requested I/O is
for vm-to-device or device-to-device.
We could still use iostat to measure throughput of individual
block devices. 

Thanks,
-- 
Jun'ichi Nomura, NEC Corporation

  reply	other threads:[~2012-03-21 10:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-21  4:05 [PATCH] Fix I/O counts in vmstat Mikulas Patocka
2012-03-21 10:04 ` Jun'ichi Nomura [this message]
2012-03-21 15:50   ` [dm-devel] " Mikulas Patocka
2012-03-22  2:06     ` Jun'ichi Nomura

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F69A798.4000200@ce.jp.nec.com \
    --to=j-nomura@ce.jp.nec.com \
    --cc=agk@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=dm-devel@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpatocka@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.