From: Oleg Zhurakivskyy <oleg.zhurakivskyy@intel.com>
To: ofono@ofono.org
Subject: Re: [PATCHv3 06/12] call-forwarding: Don't run conditional queries if cfu is active
Date: Wed, 21 Mar 2012 13:49:39 +0200 [thread overview]
Message-ID: <4F69C053.1020205@intel.com> (raw)
In-Reply-To: <4F691C2B.9070406@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1067 bytes --]
Hello Denis,
On 03/21/2012 02:09 AM, Denis Kenzior wrote:
>> static inline void get_query_next_cf_cond(struct ofono_call_forwarding *cf)
>> @@ -565,7 +564,9 @@ static DBusMessage *cf_get_properties(DBusConnection *conn, DBusMessage *msg,
>>
>> cf->pending = dbus_message_ref(msg);
>> cf->query_next = 0;
>> -
>> + cf->query_end = is_cfu_enabled(cf) ?
>> + CALL_FORWARDING_TYPE_UNCONDITIONAL :
>> + CALL_FORWARDING_TYPE_NOT_REACHABLE;
>> get_query_next_cf_cond(cf);
>>
>> return NULL;
>
> What if we're running GetProperties for the first time and CFU is active
> at the network, but for some reason (e.g. driver doesn't implement it)
> the SIM call forwarding rules are absent. Won't we query conditional
> CFs needlessly here?
Good point and thanks for pointing this. I will correct so, that once the CFU is
discovered and active, the conditional queries will be skipped.
Regards,
Oleg
--
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki
Business Identity Code: 0357606 - 4
Domiciled in Helsinki
next prev parent reply other threads:[~2012-03-21 11:49 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-13 13:46 [PATCHv3 00/12] Call forwarding state handling change Oleg Zhurakivskyy
2012-03-13 13:46 ` [PATCHv3 01/12] call-forwarding: Remove cf_list_clear() Oleg Zhurakivskyy
2012-03-19 19:03 ` Denis Kenzior
2012-03-13 13:46 ` [PATCHv3 02/12] call-forwarding: Inline get_query_next_cf_cond() Oleg Zhurakivskyy
2012-03-19 19:03 ` Denis Kenzior
2012-03-13 13:46 ` [PATCHv3 03/12] call-forwarding: Refactor cf_condition_find_with_cls() slightly Oleg Zhurakivskyy
2012-03-20 23:50 ` Denis Kenzior
2012-03-21 11:45 ` Oleg Zhurakivskyy
2012-03-13 13:46 ` [PATCHv3 04/12] call-forwarding: Refactor cf_find_unconditional() Oleg Zhurakivskyy
2012-03-20 23:51 ` Denis Kenzior
2012-03-21 11:46 ` Oleg Zhurakivskyy
2012-03-13 13:46 ` [PATCHv3 05/12] call-forwarding: Minor cleanup of set_query_cf_callback Oleg Zhurakivskyy
2012-03-20 23:54 ` Denis Kenzior
2012-03-21 11:47 ` Oleg Zhurakivskyy
2012-03-13 13:46 ` [PATCHv3 06/12] call-forwarding: Don't run conditional queries if cfu is active Oleg Zhurakivskyy
2012-03-21 0:09 ` Denis Kenzior
2012-03-21 11:49 ` Oleg Zhurakivskyy [this message]
2012-03-13 13:46 ` [PATCHv3 07/12] call-forwarding: Re-run conditional queries on cfu removal Oleg Zhurakivskyy
2012-03-13 13:46 ` [PATCHv3 08/12] call-forwarding: Toggle the cached flag on CFU changes Oleg Zhurakivskyy
2012-03-13 13:46 ` [PATCHv3 09/12] call-forwarding: Cache cfs on CFU removal Oleg Zhurakivskyy
2012-03-21 0:16 ` Denis Kenzior
2012-03-21 11:51 ` Oleg Zhurakivskyy
2012-03-13 13:46 ` [PATCHv3 10/12] call-forwarding: Re-run ss path cfs queries on cfu changes Oleg Zhurakivskyy
2012-03-13 13:46 ` [PATCHv3 11/12] call-forwarding: Cache cfs on all/all conditional removal Oleg Zhurakivskyy
2012-03-13 13:46 ` [PATCHv3 12/12] TODO: Remove completed call forwarding state task Oleg Zhurakivskyy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F69C053.1020205@intel.com \
--to=oleg.zhurakivskyy@intel.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.