From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:46330) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SAKin-0007cw-LL for qemu-devel@nongnu.org; Wed, 21 Mar 2012 08:33:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SAKie-0007vk-Ld for qemu-devel@nongnu.org; Wed, 21 Mar 2012 08:32:57 -0400 Received: from cantor2.suse.de ([195.135.220.15]:50925 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SAKie-0007vI-D7 for qemu-devel@nongnu.org; Wed, 21 Mar 2012 08:32:48 -0400 Message-ID: <4F69CA6C.8070203@suse.de> Date: Wed, 21 Mar 2012 13:32:44 +0100 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1330479314.29508.7.camel@nzhmlwks0057.ad.endace.com> <1332307597.20383.2.camel@nzhmlwks0057.ad.endace.com> In-Reply-To: <1332307597.20383.2.camel@nzhmlwks0057.ad.endace.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] Fix typo in i400FX chipset init code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: alexey.korolev@endace.com Cc: "qemu-devel@nongnu.org" , "Michael S. Tsirkin" Hi, Am 21.03.2012 06:26, schrieb Alexey Korolev: >> Hi, >> >> There is a typo in i440FX init code. This is causing problems when >> somebody wants to access 64bit PCI range. >> >> >> Signed-off-by: Alexey Korolev >> --- >> >> hw/piix_pci.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/hw/piix_pci.c b/hw/piix_pci.c >> index 3ed3d90..aab8188 100644 >> --- a/hw/piix_pci.c >> +++ b/hw/piix_pci.c >> @@ -353,7 +353,7 @@ PCIBus *i440fx_init(PCII440FXState **pi440fx_state= , int *piix3_devfn, >> b =3D i440fx_common_init("i440FX", pi440fx_state, piix3_devfn, is= a_bus, pic, >> address_space_mem, address_space_io, ram_s= ize, >> pci_hole_start, pci_hole_size, >> - pci_hole64_size, pci_hole64_size, >> + pci_hole64_start, pci_hole64_size, >> pci_memory, ram_memory); >> return b; >> } >> >> >> > Hi there, >=20 > Any chance that someone could have a look and commit this? A patch should never start with "Hi,", it should have a commit message that can be applied unmodified to git, describing what area it touches, what it changes and why. So, the the subject should start with, e.g., "i440fx: Fix start of 64-bit hole" and go on to explain where exactly that is and what it affects (does this resolve some guest-visible bug? when was it introduced? i.e., does it need to be backported?). Repeating "typo" again and again is not helpful to understand the impact of a commit when bisecting later on without seeing the code. You forgot to cc the PCI maintainer. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg