From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shea Levy Subject: Re: [PATCH v4 0/2] Add driver for Apple gmux device Date: Wed, 21 Mar 2012 08:36:47 -0400 Message-ID: <4F69CB5F.70002@shealevy.com> References: <1331926882-22979-1-git-send-email-seth.forshee@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1331926882-22979-1-git-send-email-seth.forshee@canonical.com> Sender: linux-kernel-owner@vger.kernel.org To: Seth Forshee Cc: Matthew Garrett , platform-driver-x86@vger.kernel.org, Richard Purdie , linux-kernel@vger.kernel.org List-Id: platform-driver-x86.vger.kernel.org Hi Seth, On 03/16/2012 03:41 PM, Seth Forshee wrote: > Apple laptops with hybrid graphics have a device named gmux that is used > for switching between GPUs and backlight control. On many models this is > the only reliable method for controlling the backlight. > > This series adds initial support for the gmux device, along with > anciallary support for disabling apple_bl when the gmux device is > detected. Initially only backlight control is supported. > > I've done some basic testing on my MBP 5,3 (just setting a few brightness levels, nothing fancy), and it all works, so feel free to add my basic Tested-by: Shea Levy if you wish. Please let me know if you need testing for future gmux features. A few questions: * I'm using nouveau, and with the gmux I have both gmux_backlight and nv_backlight (which never worked) in /sys/class/backlight, is this expected? * Is there anything I can do to test the backlight interface in addition to setting brightness levels? * Besides the sysfs backlight interface, are there any other userspace-visible changes your driver makes that I should test? Cheers, Shea Levy