From: Amir Vadai <amirv@mellanox.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>, <netdev@vger.kernel.org>,
Roland Dreier <roland@purestorage.com>,
Oren Duer <oren@mellanox.com>, Amir Vadai <amirv@mellanox.co.il>
Subject: Re: [PATCH V1 4/6] net/mlx4_en: Set max rate-limit for a TC
Date: Wed, 21 Mar 2012 15:43:11 +0200 [thread overview]
Message-ID: <4F69DAEF.5010407@mellanox.com> (raw)
In-Reply-To: <1332324776.25742.14.camel@edumazet-laptop>
On 03/21/2012 12:12 PM, Eric Dumazet wrote:
> Le mercredi 21 mars 2012 à 11:25 +0200, Amir Vadai a écrit :
>> From: Amir Vadai<amirv@mellanox.co.il>
>>
>> Set max rate-limit using sysfs file /sys/class/net/<interface>/qos/ratelimit
>>
>> To set, enter a space separated list of values in units of 100Mbps. For
>> example to set ratelimit of 5G to TC0 and 10G for the reset on eth2 issue:
>> echo 50 100 100 100 100 100 100 100 100> /sys/class/net/eth2/qos/ratelimit
>>
>
> Oh thats not very user friendly.
>
> I suggest one value per file (Its probably a generic /sys rule anyway)
> and not using 100Mps for the unit, even if it is the base granularity of
> this hardware.
>
>
> /sys/class/net/eth2/qos/0/ratelimit
> ...
> /sys/class/net/eth2/qos/7/ratelimit
>
>
Ok, will change the structure to be:
/sys/class/net/eth2/qos/tc0/ratelimit
...
/sys/class/net/eth2/qos/tc7/ratelimit
And use units of 1Mbps
- Amir
next prev parent reply other threads:[~2012-03-21 13:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-21 9:24 [PATCH V1 0/6] net/mlx4_en: DCB QoS support Amir Vadai
2012-03-21 9:24 ` [PATCH V1 1/6] net/mlx4_en: Force user priority by QP attribute Amir Vadai
2012-03-21 9:24 ` [PATCH V1 2/6] net/mlx4_core: set port QoS attributes Amir Vadai
2012-03-21 9:25 ` [PATCH V1 3/6] net/mlx4_en: DCB QoS support Amir Vadai
2012-03-21 9:25 ` [PATCH V1 4/6] net/mlx4_en: Set max rate-limit for a TC Amir Vadai
2012-03-21 10:12 ` Eric Dumazet
2012-03-21 13:43 ` Amir Vadai [this message]
2012-03-21 9:25 ` [PATCH V1 5/6] net/mlx4_en: sk_prio <=> UP for untagged traffic Amir Vadai
2012-03-21 14:20 ` John Fastabend
2012-03-21 15:18 ` Amir Vadai
2012-03-21 9:25 ` [PATCH V1 6/6] IB/rdma_cm: TOS <=> UP mapping for IBoE Amir Vadai
2012-03-21 10:03 ` Eric Dumazet
2012-03-21 13:26 ` Amir Vadai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F69DAEF.5010407@mellanox.com \
--to=amirv@mellanox.com \
--cc=amirv@mellanox.co.il \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=oren@mellanox.com \
--cc=roland@purestorage.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.