From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:40164)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <vianac@linux.vnet.ibm.com>) id 1SAP7q-0006uQ-1e
	for qemu-devel@nongnu.org; Wed, 21 Mar 2012 13:15:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <vianac@linux.vnet.ibm.com>) id 1SAP7i-00055Q-GQ
	for qemu-devel@nongnu.org; Wed, 21 Mar 2012 13:15:05 -0400
Received: from e24smtp03.br.ibm.com ([32.104.18.24]:33471)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <vianac@linux.vnet.ibm.com>) id 1SAP7i-00054p-4t
	for qemu-devel@nongnu.org; Wed, 21 Mar 2012 13:14:58 -0400
Received: from /spool/local
	by e24smtp03.br.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <vianac@linux.vnet.ibm.com>;
	Wed, 21 Mar 2012 14:14:53 -0300
Received: from d24relay03.br.ibm.com (d24relay03.br.ibm.com [9.13.184.25])
	by d24dlp01.br.ibm.com (Postfix) with ESMTP id 3ADF1352004A
	for <qemu-devel@nongnu.org>; Wed, 21 Mar 2012 14:14:49 -0300 (BRT)
Received: from d24av04.br.ibm.com (d24av04.br.ibm.com [9.8.31.97])
	by d24relay03.br.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	q2LHEgau38797712
	for <qemu-devel@nongnu.org>; Wed, 21 Mar 2012 14:14:42 -0300
Received: from d24av04.br.ibm.com (loopback [127.0.0.1])
	by d24av04.br.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	q2LFEbxn006481
	for <qemu-devel@nongnu.org>; Wed, 21 Mar 2012 12:14:37 -0300
Message-ID: <4F6A0C6C.4070004@linux.vnet.ibm.com>
Date: Wed, 21 Mar 2012 14:14:20 -0300
From: =?UTF-8?B?Q3LDrXN0aWFuIFZpYW5h?= <vianac@linux.vnet.ibm.com>
MIME-Version: 1.0
References: <1332277190-14477-1-git-send-email-vianac@linux.vnet.ibm.com>
	<1332277190-14477-2-git-send-email-vianac@linux.vnet.ibm.com>
	<jkbqst$bku$1@dough.gmane.org>
In-Reply-To: <jkbqst$bku$1@dough.gmane.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH v2 2/2] Change timedrift default value to
 slew
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org

On 21-03-2012 03:02, Paolo Bonzini wrote:
> This piece of code from the previous if:
> 
>         if (!strcmp(value, "slew")) {
>             static GlobalProperty slew_lost_ticks[] = {
>                 {
>                     .driver   = "mc146818rtc",
>                     .property = "lost_tick_policy",
>                     .value    = "slew",
>                 },
>                 { /* end of list */ }
>             };
> 
>             qdev_prop_register_global_list(slew_lost_ticks);
> 
> needs to be adjusted and moved to the "if (!strmp(value, "none"))" branch.

Thanks, Paolo! I sent a version 3 of these patches with the changes you
suggested.

-- 
Best regards,
Crístian.