From: Gianluca Gennari <gennarone@gmail.com>
To: "Michael Büsch" <m@bues.ch>
Cc: Hans-Frieder Vogt <hfvogt@gmx.net>,
linux-media <linux-media@vger.kernel.org>
Subject: Re: [PATCH 1/2] Fitipower fc0011 driver
Date: Wed, 21 Mar 2012 20:12:03 +0100 [thread overview]
Message-ID: <4F6A2803.40208@gmail.com> (raw)
In-Reply-To: <20120321165645.37ea9246@milhouse>
Il 21/03/2012 16:56, Michael Büsch ha scritto:
> This adds the Fitipower fc0011 tuner driver.
>
> Note: The '#if 0' statements will be removed on the final submission.
>
> Signed-off-by: Michael Buesch <m@bues.ch>
>
> ---
......
> +
> +#if 0 //TODO 3.3
> +static int fc0011_set_params(struct dvb_frontend *fe)
> +#else
> +static int fc0011_set_params(struct dvb_frontend *fe,
> + struct dvb_frontend_parameters *params)
> +#endif
> +{
> + struct fc0011_priv *priv = fe->tuner_priv;
> + int err;
> + unsigned int i;
> +#if 0 //TODO 3.3
> + struct dtv_frontend_properties *p = &fe->dtv_property_cache;
> + u32 freq = p->frequency / 1000;
> + u32 delsys = p->delivery_system;
The "delsys" variable is unused, you can delete it.
BTW, I only compiled the driver, as I don't have the hardware to test it.
Regards,
Gianluca
> + u32 bandwidth = p->bandwidth_hz / 1000;
> +#else
> + u32 freq = params->frequency / 1000;
> + u32 bandwidth = params->u.ofdm.bandwidth / 1000;
> +#endif
next prev parent reply other threads:[~2012-03-21 19:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120321160237.02193470@milhouse>
2012-03-21 15:56 ` [PATCH 1/2] Fitipower fc0011 driver Michael Büsch
2012-03-21 19:12 ` Gianluca Gennari [this message]
2012-03-21 20:09 ` Michael Büsch
2012-03-21 15:56 ` [PATCH 2/2] Integrate Fitipower fc0011 into af903x Michael Büsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F6A2803.40208@gmail.com \
--to=gennarone@gmail.com \
--cc=hfvogt@gmx.net \
--cc=linux-media@vger.kernel.org \
--cc=m@bues.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.