From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:56927)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1SATDS-00055g-Dt
	for qemu-devel@nongnu.org; Wed, 21 Mar 2012 17:37:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1SATDQ-0005zq-8f
	for qemu-devel@nongnu.org; Wed, 21 Mar 2012 17:37:09 -0400
Received: from mail-pz0-f45.google.com ([209.85.210.45]:51063)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1SATDP-0005z9-KH
	for qemu-devel@nongnu.org; Wed, 21 Mar 2012 17:37:07 -0400
Received: by dadp14 with SMTP id p14so2498337dad.4
	for <qemu-devel@nongnu.org>; Wed, 21 Mar 2012 14:37:04 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4F6A49F2.5080503@redhat.com>
Date: Wed, 21 Mar 2012 22:36:50 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1332345997-4772-1-git-send-email-vianac@linux.vnet.ibm.com>
In-Reply-To: <1332345997-4772-1-git-send-email-vianac@linux.vnet.ibm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH v3 1/2] Force timedrift=none on previous
	machines
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?Q3LDrXN0aWFuIFZpYW5h?= <vianac@linux.vnet.ibm.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>

Il 21/03/2012 17:06, Crístian Viana ha scritto:
> The current value for the -rtc timedrift option is none. This patch
> makes sure that the old machines configuration will work the same way
> even after that option changes its default value.
> 
> Signed-off-by: Crístian Viana <vianac@linux.vnet.ibm.com>
> ---
>  hw/pc_piix.c |   39 +++++++++++++++++++++++++++++++++++++++
>  1 files changed, 39 insertions(+), 0 deletions(-)
> 
> diff --git a/hw/pc_piix.c b/hw/pc_piix.c
> index 3f99f9a..08255b5 100644
> --- a/hw/pc_piix.c
> +++ b/hw/pc_piix.c
> @@ -386,6 +386,10 @@ static QEMUMachine pc_machine_v1_0 = {
>              .driver   = "isa-fdc",
>              .property = "check_media_rate",
>              .value    = "off",
> +        }, {
> +            .driver   = "mc146818rtc",
> +            .property = "lost_tick_policy",
> +            .value    = "none",
>          },
>          { /* end of list */ }
>      },
> @@ -405,6 +409,10 @@ static QEMUMachine pc_machine_v0_15 = {
>              .driver   = "isa-fdc",
>              .property = "check_media_rate",
>              .value    = "off",
> +        }, {
> +            .driver   = "mc146818rtc",
> +            .property = "lost_tick_policy",
> +            .value    = "none",
>          },
>          { /* end of list */ }
>      },
> @@ -449,6 +457,10 @@ static QEMUMachine pc_machine_v0_14 = {
>              .driver   = "pc-sysfw",
>              .property = "rom_only",
>              .value    = stringify(1),
> +        }, {
> +            .driver   = "mc146818rtc",
> +            .property = "lost_tick_policy",
> +            .value    = "none",
>          },
>          { /* end of list */ }
>      },
> @@ -505,6 +517,10 @@ static QEMUMachine pc_machine_v0_13 = {
>              .driver   = "pc-sysfw",
>              .property = "rom_only",
>              .value    = stringify(1),
> +        }, {
> +            .driver   = "mc146818rtc",
> +            .property = "lost_tick_policy",
> +            .value    = "none",
>          },
>          { /* end of list */ }
>      },
> @@ -565,6 +581,10 @@ static QEMUMachine pc_machine_v0_12 = {
>              .driver   = "pc-sysfw",
>              .property = "rom_only",
>              .value    = stringify(1),
> +        }, {
> +            .driver   = "mc146818rtc",
> +            .property = "lost_tick_policy",
> +            .value    = "none",
>          },
>          { /* end of list */ }
>      }
> @@ -633,6 +653,10 @@ static QEMUMachine pc_machine_v0_11 = {
>              .driver   = "pc-sysfw",
>              .property = "rom_only",
>              .value    = stringify(1),
> +        }, {
> +            .driver   = "mc146818rtc",
> +            .property = "lost_tick_policy",
> +            .value    = "none",
>          },
>          { /* end of list */ }
>      }
> @@ -713,6 +737,10 @@ static QEMUMachine pc_machine_v0_10 = {
>              .driver   = "pc-sysfw",
>              .property = "rom_only",
>              .value    = stringify(1),
> +        }, {
> +            .driver   = "mc146818rtc",
> +            .property = "lost_tick_policy",
> +            .value    = "none",
>          },
>          { /* end of list */ }
>      },
> @@ -728,6 +756,10 @@ static QEMUMachine isapc_machine = {
>              .driver   = "pc-sysfw",
>              .property = "rom_only",
>              .value    = stringify(1),
> +        }, {
> +            .driver   = "mc146818rtc",
> +            .property = "lost_tick_policy",
> +            .value    = "none",
>          },
>          { /* end of list */ }
>      },
> @@ -740,6 +772,13 @@ static QEMUMachine xenfv_machine = {
>      .init = pc_xen_hvm_init,
>      .max_cpus = HVM_MAX_VCPUS,
>      .default_machine_opts = "accel=xen",
> +    .compat_props = (GlobalProperty[]) {
> +        {
> +            .driver   = "mc146818rtc",
> +            .property = "lost_tick_policy",
> +            .value    = "none",
> +        },
> +        { /* end of list */ }
>  };
>  #endif
>  

Stefano, what do you want for Xen?  Anyhow,

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>

Paolo