From: Mike Christie <michaelc@cs.wisc.edu>
To: Rolf Eike Beer <eike-kernel@sf-tec.de>
Cc: linux-scsi@vger.kernel.org,
Jayamohan Kallickal <jayamohan.kallickal@emulex.com>,
Minh Tran <MinhDuc.Tran@emulex.com>
Subject: Re: [PATCH 05/17] be2iscsi:Fix typo function name mismatch
Date: Wed, 21 Mar 2012 18:57:18 -0500 [thread overview]
Message-ID: <4F6A6ADE.8080203@cs.wisc.edu> (raw)
In-Reply-To: <5978796.vmDf5npbmM@eto>
On 03/21/2012 05:21 PM, Rolf Eike Beer wrote:
> Am Dienstag 20 März 2012, 20:47:56 schrieb michaelc@cs.wisc.edu:
>> From: Jayamohan Kallickal <jayamohan.kallickal@emulex.com>
>>
>> Signed-off-by: Minh Tran <MinhDuc.Tran@Emulex.Com>
>> Signed-off-by: Jayamohan Kallickal <jayamohan.kallickal@emulex.com>
>> Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
>> ---
>> drivers/scsi/be2iscsi/be_iscsi.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/scsi/be2iscsi/be_iscsi.c
>> b/drivers/scsi/be2iscsi/be_iscsi.c index 33c8f09..2bb681e 100644
>> --- a/drivers/scsi/be2iscsi/be_iscsi.c
>> +++ b/drivers/scsi/be2iscsi/be_iscsi.c
>> @@ -221,7 +221,7 @@ int beiscsi_ep_get_param(struct iscsi_endpoint *ep,
>> struct beiscsi_endpoint *beiscsi_ep = ep->dd_data;
>> int len = 0;
>>
>> - SE_DEBUG(DBG_LVL_8, "In beiscsi_conn_get_param, param= %d\n", param);
>> + SE_DEBUG(DBG_LVL_8, "In beiscsi_ep_get_param, param= %d\n", param);
>>
>> switch (param) {
>> case ISCSI_PARAM_CONN_PORT:
>
> What about:
>
> SE_DEBUG(DBG_LVL_8, "In %s, param= %d\n", __func__, param);
>
Right now the rest of the driver does it the way in the patch, so that
is why I kept the current style. In another patch I was going to go
through the driver and modify the SE_DEBUG DBG_LEVEL stuff so that it
did what you suggest for all functions. The patchset was getting large
so I wanted to get the fix done, then do the major change that modifies
all logging in another patch in the next set.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-03-21 23:58 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-21 1:47 be2iscsi update michaelc
2012-03-21 1:47 ` [PATCH 01/17] be2iscsi: Fix in the Asynchronous Code Path michaelc
2012-03-21 1:47 ` [PATCH 02/17] be2iscsi: Fix in ASYNC PDU stitching logic michaelc
2012-03-21 1:47 ` [PATCH 03/17] be2iscsi:WRB Initialization and Failure code path change michaelc
2012-03-21 1:47 ` [PATCH 04/17] be2iscsi:Freeing of WRB and SGL Handle in cleanup task michaelc
2012-03-21 1:47 ` [PATCH 05/17] be2iscsi:Fix typo function name mismatch michaelc
2012-03-21 22:21 ` Rolf Eike Beer
2012-03-21 23:57 ` Mike Christie [this message]
2012-03-22 7:52 ` James Bottomley
2012-03-21 1:47 ` [PATCH 06/17] be2iscsi:Set num_cpu = 1 if pci_enable_msix fails michaelc
2012-03-21 1:47 ` [PATCH 07/17] be2iscsi:Fix double free of MCCQ info memory michaelc
2012-03-21 1:47 ` [PATCH 08/17] be2iscsi:Code cleanup, removing the goto statement michaelc
2012-03-21 1:48 ` [PATCH 09/17] be2iscsi:Fix the function return values michaelc
2012-03-21 1:48 ` [PATCH 10/17] be2iscsi: Update in Copyright information michaelc
2012-03-21 1:48 ` [PATCH 11/17] be2iscsi:Bump the driver Version michaelc
2012-03-21 1:48 ` [PATCH 12/17] be2iscsi: Check ASYNC PDU Handle corresponds to HDR/DATA Handle michaelc
2012-03-21 1:48 ` [PATCH 13/17] be2iscsi: Return async handle of unknown opcode to free list michaelc
2012-03-21 1:48 ` [PATCH 14/17] be2iscsi: Get Initiator Name for the iSCSI_Host michaelc
2012-03-21 1:48 ` [PATCH 15/17] be2iscsi: Adding bsg interface for be2iscsi michaelc
2012-03-21 1:48 ` [PATCH 16/17] be2iscsi: adding functionality to change network settings using iscsiadm michaelc
2012-03-21 1:48 ` [PATCH 17/17] be2iscsi: Get Port State and Speed of the Adapter michaelc
2012-04-04 4:04 ` be2iscsi update Mike Christie
-- strict thread matches above, loose matches on Subject: below --
2012-04-04 4:41 be2iscsi update v2 michaelc
2012-04-04 4:41 ` [PATCH 05/17] be2iscsi:Fix typo function name mismatch michaelc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F6A6ADE.8080203@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=MinhDuc.Tran@emulex.com \
--cc=eike-kernel@sf-tec.de \
--cc=jayamohan.kallickal@emulex.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.