[PATCH] runningbuild.py: fix goggle ui

[PATCH] runningbuild.py: fix goggle ui

[Eric Bénard]

* goggle ui actually fails with :
Traceback (most recent call last):
  File ".../bitbake/lib/bb/ui/goggle.py", line 35, in event_handle_idle_func
    build.handle_event (event, pbar)
  File ".../bitbake/lib/bb/ui/crumbs/runningbuild.py", line 234, in handle_event
    pbar.update(0, None, bb.event.getName(event))
TypeError: update() takes exactly 3 arguments (4 given)

Signed-off-by: Eric Bénard <eric@eukrea.com>
---
 lib/bb/ui/crumbs/runningbuild.py |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/bb/ui/crumbs/runningbuild.py b/lib/bb/ui/crumbs/runningbuild.py
index 718f692..10ca394 100644
--- a/lib/bb/ui/crumbs/runningbuild.py
+++ b/lib/bb/ui/crumbs/runningbuild.py
@@ -231,8 +231,8 @@ class RunningBuild (gobject.GObject):
                                       HobColors.OK,
                                       0))
             if pbar:
-                pbar.update(0, None, bb.event.getName(event))
-                pbar.set_title()
+                pbar.update(0, self.progress_total)
+                pbar.set_title(bb.event.getName(event))
 
         elif isinstance(event, bb.event.BuildCompleted):
             failures = int (event._failures)
-- 
1.7.7.6

Re: [PATCH] runningbuild.py: fix goggle ui

[Richard Purdie]

On Mon, 2012-03-19 at 12:56 +0100, Eric Bénard wrote:
> * goggle ui actually fails with :
> Traceback (most recent call last):
>   File ".../bitbake/lib/bb/ui/goggle.py", line 35, in event_handle_idle_func
>     build.handle_event (event, pbar)
>   File ".../bitbake/lib/bb/ui/crumbs/runningbuild.py", line 234, in handle_event
>     pbar.update(0, None, bb.event.getName(event))
> TypeError: update() takes exactly 3 arguments (4 given)
> 
> Signed-off-by: Eric Bénard <eric@eukrea.com>

Merged to master, thanks.

Richard

[PATCH] runningbuild.py: fix goggle ui

[Eric Bénard]

without this fix I get the following error once the build is finished :
Traceback (most recent call last):
  File ".../bitbake/lib/bb/ui/goggle.py", line 35, in event_handle_idle_func
    build.handle_event (event, pbar)
  File ".../bitbake/lib/bb/ui/crumbs/runningbuild.py", line 287, in handle_event
    pbar.set_text(event.msg)
AttributeError: 'ProgressBar' object has no attribute 'set_text'

Signed-off-by: Eric Bénard <eric@eukrea.com>
---
 lib/bb/ui/crumbs/runningbuild.py |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lib/bb/ui/crumbs/runningbuild.py b/lib/bb/ui/crumbs/runningbuild.py
index 4c3fe2c..343eac9 100644
--- a/lib/bb/ui/crumbs/runningbuild.py
+++ b/lib/bb/ui/crumbs/runningbuild.py
@@ -284,7 +284,7 @@ class RunningBuild (gobject.GObject):
             # handle when the build is finished
             self.emit("build-complete")
             if pbar:
-                pbar.set_text(event.msg)
+                pbar.set_title(event.msg)
 
         elif isinstance(event, bb.command.CommandFailed):
             if event.error.startswith("Exited with"):
-- 
1.7.7.6

Re: [PATCH] runningbuild.py: fix goggle ui

[Joshua Lock]

On 21/03/12 08:44, Eric Bénard wrote:
> without this fix I get the following error once the build is finished :
> Traceback (most recent call last):
>    File ".../bitbake/lib/bb/ui/goggle.py", line 35, in event_handle_idle_func
>      build.handle_event (event, pbar)
>    File ".../bitbake/lib/bb/ui/crumbs/runningbuild.py", line 287, in handle_event
>      pbar.set_text(event.msg)
> AttributeError: 'ProgressBar' object has no attribute 'set_text'
>
> Signed-off-by: Eric Bénard<eric@eukrea.com>
Signed-off-by: Joshua Lock <josh@linux.intel.com>

> ---
>   lib/bb/ui/crumbs/runningbuild.py |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/lib/bb/ui/crumbs/runningbuild.py b/lib/bb/ui/crumbs/runningbuild.py
> index 4c3fe2c..343eac9 100644
> --- a/lib/bb/ui/crumbs/runningbuild.py
> +++ b/lib/bb/ui/crumbs/runningbuild.py
> @@ -284,7 +284,7 @@ class RunningBuild (gobject.GObject):
>               # handle when the build is finished
>               self.emit("build-complete")
>               if pbar:
> -                pbar.set_text(event.msg)
> +                pbar.set_title(event.msg)
>
>           elif isinstance(event, bb.command.CommandFailed):
>               if event.error.startswith("Exited with"):

-- 
Joshua '贾詡' Lock
         Yocto Project "Johannes factotum"
         Intel Open Source Technology Centre