From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59465) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SAj9C-0004KN-S4 for qemu-devel@nongnu.org; Thu, 22 Mar 2012 10:38:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SAj96-00016x-Fu for qemu-devel@nongnu.org; Thu, 22 Mar 2012 10:37:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45372) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SAj96-00016Y-85 for qemu-devel@nongnu.org; Thu, 22 Mar 2012 10:37:44 -0400 Message-ID: <4F6B3933.20708@redhat.com> Date: Thu, 22 Mar 2012 15:37:39 +0100 From: Gerd Hoffmann MIME-Version: 1.0 References: <1332418064-23091-1-git-send-email-kraxel@redhat.com> <4F6B30A8.6060903@suse.de> In-Reply-To: <4F6B30A8.6060903@suse.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] usb/vmstate: add parent dev path List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-15?Q?Andreas_F=E4rber?= Cc: Paolo Bonzini , qemu-devel@nongnu.org, Anthony Liguori Hi, >> + .driver = "USB", >> + .property = "full-path", >> + .value = "no", > > This touches on our "favorite" bit/bool topic again. While I agree that > "no" makes sense for a property of that name, the current code still > expects "on" and "off". In particular, "yes" would not work as expected. "no" *does* work as expected though, at least it survived my tests, thats why I didn't notice. I can s/no/off/ for consistency, no problem. Merging your yes/no patch is fine with me too. cheers, Gerd