From mboxrd@z Thu Jan 1 00:00:00 1970 From: Attilio Rao Subject: Re: Build failure in OVMF Date: Thu, 22 Mar 2012 15:23:15 +0000 Message-ID: <4F6B43E3.4090801@citrix.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Keir Fraser Cc: "g@phlegethon.org" , "Tim (Xen.org)" , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On 22/03/12 13:58, Keir Fraser wrote: > On 22/03/2012 13:15, "Tim Deegan" wrote: > > >> At 13:07 +0000 on 22 Mar (1332421679), Attilio Rao wrote: >> >>> Actually CONFIG_OVMF should be disabled by default, can you please check >>> how is in your case? >>> >> whitby:xen-unstable.hg$ grep CONFIG_OVMF Config.mk >> CONFIG_OVMF ?= $(CONFIG_Linux) >> >> changeset: 25077:6bf50858c3c5 >> user: Attilio Rao >> date: Thu Mar 22 10:26:03 2012 +0000 >> summary: Fetch the OVMF repository from specific git mirror and enable >> it >> >> >>> Also, did you apply the OVMF v4 patch for enabling the CONFIG_OVMF on? >>> >> Nope, AFAICT I have no local patches. >> > I applied the OVMF-enable patch this morning, hence Tim's problem. I might > have applied v3 rather than v4 though? Please check. > > I actually think you have applied the right patch, there is just a situation in OVMF binary building that we need to cope with, my bad for not having better checked. For the moment, please disable OVMF by default building, I'll send you more patches and when the upstream TIANOCORE will have fixes in I will send an explicit patch to enable it. Thanks, Attilio