From: Joshua Lock <josh@linux.intel.com>
To: "Wang, Shane" <shane.wang@intel.com>
Cc: "bitbake-devel@lists.openembedded.org"
<bitbake-devel@lists.openembedded.org>
Subject: Re: [PATCH 00/10] Hob GUI tweaks v2
Date: Thu, 22 Mar 2012 10:05:56 -0700 [thread overview]
Message-ID: <4F6B5BF4.8040501@linux.intel.com> (raw)
In-Reply-To: <3AB6CE7F274E534CAFD089D127A8A1FC23AF612C@SHSMSX102.ccr.corp.intel.com>
On 22/03/12 01:39, Wang, Shane wrote:
> 05, I think we need more work, the label on the button is blue. I hope we can make the labels colorful to highlight there is a button for click. Again, for "Back to XXX", the design is "<< Back to XXX". But I can ACK to check in the patch first, and leave the work for future.
Agreed, I mentioned the need to create a follow-on patch for the colour
in the pull message. I'll work on that today.
I see the design also includes the << on Back buttons, I'll include a
patch to re-add those in today's series - apologies for missing that.
> 07, the machine combo box vertically is not in the middle of "layers" button, and it removes the hover function, that is when the mouse is over the button, the icon will be changed. Initially we implemented that in this way, however it didn't look good. So, we used our specific solution. What the designer expects is it becomes a button. That could be implemented.
Right you are, I'd missed that on the design also. I'll fix this and
ensure the use of the hover state in a follow on patch.
Cheers,
Joshua
--
Joshua '贾詡' Lock
Yocto Project "Johannes factotum"
Intel Open Source Technology Centre
prev parent reply other threads:[~2012-03-22 17:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-22 2:10 [PATCH 00/10] Hob GUI tweaks v2 Joshua Lock
2012-03-22 2:10 ` [PATCH 01/10] ui/crumbs/hobwidget: add clear icon to search entries in HobNotebook Joshua Lock
2012-03-22 2:10 ` [PATCH 02/10] ui/crumbs/persistenttooltip: tweak borders Joshua Lock
2012-03-22 2:10 ` [PATCH 03/10] ui/crumbs/persistenttooltip: fix colours on darker themes Joshua Lock
2012-03-22 2:10 ` [PATCH 04/10] ui/crumbs/persistenttooltip: fix whitespace Joshua Lock
2012-03-22 2:10 ` [PATCH 05/10] lib/bb/ui/crumbs: Add HobAltButton and use it Joshua Lock
2012-03-22 2:10 ` [PATCH 06/10] lib/ui/icons: autocrop images Joshua Lock
2012-03-22 2:10 ` [PATCH 07/10] lib/bb/ui/crumbs: replace HobXpmLabelButtonBox with HobImageButton Joshua Lock
2012-03-22 2:10 ` [PATCH 08/10] lib/bb/ui/crumbs: add icons for use in the layer dialogue Joshua Lock
2012-03-22 2:10 ` [PATCH 09/10] ui/crumbs/hig: make the layer selection dialogue more closely match design Joshua Lock
2012-03-22 2:10 ` [PATCH 10/10] lib/bb/ui/crumbs/hig: disable removal of meta-hob layer Joshua Lock
2012-03-22 2:12 ` [PATCH 00/10] Hob GUI tweaks v2 Joshua Lock
2012-03-22 8:39 ` Wang, Shane
2012-03-22 17:05 ` Joshua Lock [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F6B5BF4.8040501@linux.intel.com \
--to=josh@linux.intel.com \
--cc=bitbake-devel@lists.openembedded.org \
--cc=shane.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.