Re: [PATCH] x86, build: remove unused include

["H. Peter Anvin" <hpa@zytor.com>]

On 03/22/2012 03:17 AM, Andreas Bießmann wrote:
> On Wed, Feb 15, 2012 at 05:49:49PM +0100, Andreas Bießmann wrote:
>> Commit 079f85e624189292d1c818b47764916bf8cf84a8 removed necessity for
>> sys/sysmacros.h include but missed to remove the include.
>>
>> Still requiring sys/sysmacros.h for build tool breaks cross compiling x86 kernel
>> on non linux style systems which may not offer sys/sysmacros.h.
>>
>> Signed-off-by: Andreas Bießmann <andreas@biessmann.de>
>> ---
>>  arch/x86/boot/tools/build.c |    1 -
>>  1 files changed, 0 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/x86/boot/tools/build.c b/arch/x86/boot/tools/build.c
>> index 4e9bd6b..52628cd 100644
>> --- a/arch/x86/boot/tools/build.c
>> +++ b/arch/x86/boot/tools/build.c
>> @@ -29,7 +29,6 @@
>>  #include <stdarg.h>
>>  #include <sys/types.h>
>>  #include <sys/stat.h>
>> -#include <sys/sysmacros.h>
>>  #include <unistd.h>
>>  #include <fcntl.h>
>>  #include <sys/mman.h>
>> -- 
> 
> are there any objections against that patch? could anyone take it if not?

An equivalent patch has been in tip:x86/build for a while and was just
pulled upstream by Linus.

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.