From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:54113)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1SAocC-00080X-72
	for qemu-devel@nongnu.org; Thu, 22 Mar 2012 16:28:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1SAocA-0002hL-8W
	for qemu-devel@nongnu.org; Thu, 22 Mar 2012 16:28:07 -0400
Received: from mail-yx0-f173.google.com ([209.85.213.173]:43796)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1SAocA-0002h6-4N
	for qemu-devel@nongnu.org; Thu, 22 Mar 2012 16:28:06 -0400
Received: by yenr5 with SMTP id r5so2603219yen.4
	for <qemu-devel@nongnu.org>; Thu, 22 Mar 2012 13:28:04 -0700 (PDT)
Message-ID: <4F6B8B50.9090100@codemonkey.ws>
Date: Thu, 22 Mar 2012 15:28:00 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1332417072-20329-1-git-send-email-pbonzini@redhat.com>
	<1332417072-20329-11-git-send-email-pbonzini@redhat.com>
In-Reply-To: <1332417072-20329-11-git-send-email-pbonzini@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 10/10] qmp: parse commands in strict mode
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: lcapitulino@redhat.com, eblake@redhat.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com

On 03/22/2012 06:51 AM, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini<pbonzini@redhat.com>

Reviewed-off-by: Anthony Liguori <aliguori@us.ibm.com>

Looks good overall.  I think documentation is the only real issue.

I assume this will go through Luiz's tree?

Regards,

Anthony Liguori

> ---
>   scripts/qapi-commands.py |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/scripts/qapi-commands.py b/scripts/qapi-commands.py
> index 3aabf61..4774b61 100644
> --- a/scripts/qapi-commands.py
> +++ b/scripts/qapi-commands.py
> @@ -140,7 +140,7 @@ v = qapi_dealloc_get_visitor(md);
>   ''')
>       else:
>           ret += mcgen('''
> -mi = qmp_input_visitor_new(%(obj)s);
> +mi = qmp_input_visitor_new_strict(%(obj)s);
>   v = qmp_input_get_visitor(mi);
>   ''',
>                        obj=obj)