From: Igor Grinberg <grinberg@compulab.co.il>
To: Russ Dill <Russ.Dill@ti.com>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
linux-omap@vger.kernel.org, Tony Lindgren <tony@atomide.com>,
Matt Porter <mporter@ti.com>,
robert.marklund@stericsson.com, linus.walleij@linaro.org
Subject: Re: [PATCH 13/13] Add dummy smsc911x regulators to zoom-debugboard.
Date: Fri, 23 Mar 2012 10:49:10 +0200 [thread overview]
Message-ID: <4F6C3906.5070605@compulab.co.il> (raw)
In-Reply-To: <CA+Bv8XZudbzx_CpiYzOJ5q9BvcBDJiWzxfCakEGzODN-6Mv03Q@mail.gmail.com>
Hi Russ, Mark,
On 03/22/12 20:29, Russ Dill wrote:
> On Thu, Mar 22, 2012 at 4:37 AM, Mark Brown
> <broonie@opensource.wolfsonmicro.com> wrote:
>> On Wed, Mar 21, 2012 at 10:19:54PM -0700, Russ Dill wrote:
>>
>>> +static struct regulator_consumer_supply dummy_supplies[] = {
>>> + REGULATOR_SUPPLY("vddvario", "smsc911x.0"),
>>> + REGULATOR_SUPPLY("vdd33a", "smsc911x.0"),
>>
>> Why do none of these boards use -1 as the ID for the device?
>
> Commit 21b42731 (omap: convert boards that use SMSC911x to use
> gpmc-smsc911x) changed several board files to use the gpmc-smsc911x.c
> common code rather than register the device themselves, in the process
> it changed many of the id's from -1 to 0. This happened in the 3.0
> merge window. I can certainly change it back.
IIRC, everybody were very sensible to each new l-o-f back then,
so making the id = 0 (leaving it uninitialized) helped with
reducing some ~10 lines more...
Of course we can change this now, but what is the real problem
with having device id = 0 and not -1?
--
Regards,
Igor.
prev parent reply other threads:[~2012-03-23 8:49 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-16 11:32 smsc911x on Gumstix Overo/Tobi doesn't work Thomas Klute
2012-03-16 19:33 ` Tony Lindgren
2012-03-19 16:23 ` Thomas Klute
2012-03-19 22:51 ` Tony Lindgren
2012-03-20 14:27 ` Thomas Klute
2012-03-20 19:47 ` Javier Martinez Canillas
2012-03-21 16:29 ` Thomas Klute
2012-03-30 15:28 ` Thomas Klute
2012-04-01 19:20 ` Javier Martinez Canillas
2012-05-02 11:42 ` Thomas Klute
2012-05-03 11:09 ` Javier Martinez Canillas
2012-05-09 11:47 ` Thomas Klute
2012-03-21 17:55 ` [PATCH] [RFC] Correct registration of multiple gpmc smsc911x devices Russ Dill
2012-03-21 18:13 ` Mark Brown
2012-03-21 18:18 ` Porter, Matt
2012-03-21 18:24 ` Porter, Matt
2012-03-21 18:39 ` Tony Lindgren
2012-03-21 19:00 ` Mark Brown
2012-03-21 19:30 ` Tony Lindgren
2012-03-21 19:38 ` Mark Brown
2012-03-21 19:41 ` Tony Lindgren
2012-03-21 20:45 ` Russ Dill
2012-03-22 5:19 ` [PATCH 00/13] Fixup gmpc smsc911x regulator handling Russ Dill
2012-03-22 5:19 ` [PATCH 01/13] Remove odd gpmc_cfg/board_data redirection Russ Dill
2012-03-22 5:19 ` [PATCH 02/13] Fix possible stale smsc911x flags Russ Dill
2012-03-22 5:19 ` [PATCH 03/13] Remove unused rate calculation Russ Dill
2012-03-22 5:19 ` [PATCH 04/13] Remove non-existent parameter from fixed-helper.c kernel doc Russ Dill
2012-03-22 11:36 ` Mark Brown
2012-03-22 18:30 ` Russ Dill
2012-03-22 5:19 ` [PATCH 05/13] Remove regulator support from gmpc-smsc911x Russ Dill
2012-03-22 5:19 ` [PATCH 06/13] Add dummy smsc911x regulators to cm-t35 Russ Dill
2012-03-22 5:19 ` [PATCH 07/13] Add dummy smsc911x regulators to igep0020 Russ Dill
2012-03-22 5:19 ` [PATCH 08/13] Add dummy smsc911x regulators to ldp Russ Dill
2012-03-22 7:06 ` Koen Kooi
2012-03-22 5:19 ` [PATCH 09/13] Add dummy smsc911x regulators to omap3evm Russ Dill
2012-03-22 7:07 ` Koen Kooi
2012-03-22 7:16 ` Russ Dill
2012-03-22 5:19 ` [PATCH 10/13] Add dummy smsc911x regulators to omap3logic Russ Dill
2012-03-22 5:19 ` [PATCH 11/13] Add dummy smsc911x regulators to omap3stalker Russ Dill
2012-03-22 5:19 ` [PATCH 12/13] Add dummy smsc911x regulators to overo Russ Dill
2012-03-22 5:19 ` [PATCH 13/13] Add dummy smsc911x regulators to zoom-debugboard Russ Dill
2012-03-22 11:37 ` Mark Brown
2012-03-22 18:29 ` Russ Dill
2012-03-23 8:49 ` Igor Grinberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F6C3906.5070605@compulab.co.il \
--to=grinberg@compulab.co.il \
--cc=Russ.Dill@ti.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linus.walleij@linaro.org \
--cc=linux-omap@vger.kernel.org \
--cc=mporter@ti.com \
--cc=robert.marklund@stericsson.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.