From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] configs: imx: Use CONFIG_SF_DEFAULT_CS
Date: Fri, 23 Mar 2012 10:08:12 +0100 [thread overview]
Message-ID: <4F6C3D7C.3090608@denx.de> (raw)
In-Reply-To: <201203230939.35441.marex@denx.de>
On 23/03/2012 09:39, Marek Vasut wrote:
> Dear Fabio Estevam,
>
>> CONFIG_SPI_FLASH_CS is not used anywhere.
>>
>> Use CONFIG_SF_DEFAULT_CS instead.
>>
>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>> ---
>> include/configs/efikamx.h | 2 +-
>> include/configs/m28evk.h | 2 +-
>> include/configs/vision2.h | 2 +-
>> 3 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/include/configs/efikamx.h b/include/configs/efikamx.h
>> index af542fa..120055f 100644
>> --- a/include/configs/efikamx.h
>> +++ b/include/configs/efikamx.h
>> @@ -113,7 +113,7 @@
>>
>> #define CONFIG_SPI_FLASH
>> #define CONFIG_SPI_FLASH_SST
>> -#define CONFIG_SPI_FLASH_CS (1 | 121 << 8)
>> +#define CONFIG_SF_DEFAULT_CS (1 | 121 << 8)
>> #define CONFIG_SF_DEFAULT_MODE (SPI_MODE_0)
>> #define CONFIG_SF_DEFAULT_SPEED 25000000
>>
>> diff --git a/include/configs/m28evk.h b/include/configs/m28evk.h
>> index 4d59153..4b97c71 100644
>> --- a/include/configs/m28evk.h
>> +++ b/include/configs/m28evk.h
>> @@ -252,7 +252,7 @@
>> #ifdef CONFIG_CMD_SF
>> #define CONFIG_SPI_FLASH
>> #define CONFIG_SPI_FLASH_STMICRO
>> -#define CONFIG_SPI_FLASH_CS 2
>> +#define CONFIG_SF_DEFAULT_CS 2
>
> are you sure about this? Are you sure this does the same thing?
Are we sure that CONFIG_SPI_FLASH_CS has still a meaning ? It seems to
me that SPI flash uses now CONFIG_SF_DEFAULT_CS, and we should exchange
other boards exactly as Fabio does for mx28evk. Is there still code
using CONFIG_SPI_FLASH_CS ?
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
next prev parent reply other threads:[~2012-03-23 9:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-23 0:29 [U-Boot] [PATCH 1/2] mx28evk: Provide default values for SPI bus and chip select Fabio Estevam
2012-03-23 0:29 ` [U-Boot] [PATCH 2/2] configs: imx: Use CONFIG_SF_DEFAULT_CS Fabio Estevam
2012-03-23 8:39 ` Marek Vasut
2012-03-23 9:08 ` Stefano Babic [this message]
2012-03-23 9:18 ` Marek Vasut
2012-03-23 9:26 ` Stefano Babic
2012-03-23 9:30 ` Stefano Babic
2012-03-23 8:38 ` [U-Boot] [PATCH 1/2] mx28evk: Provide default values for SPI bus and chip select Marek Vasut
2012-03-23 9:30 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F6C3D7C.3090608@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.